Commit 716da6ce authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Apply snake_case to generated CSSOMKeywords.cpp and CSSOMTypes.cpp.

According to existing data members and a script name, 'CSSOMFoo' should
be converted to 'cssom_foo', not 'css_om_foo'.

This CL has no behavior changes.

Bug: 770603
Change-Id: Iec7bfac69600c0f5f962cfa089c7bf07b8c16d73
Reviewed-on: https://chromium-review.googlesource.com/963159Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543310}
parent 51dd1f71
...@@ -15,7 +15,7 @@ import template_expander ...@@ -15,7 +15,7 @@ import template_expander
class CSSOMTypesWriter(json5_generator.Writer): class CSSOMTypesWriter(json5_generator.Writer):
""" """
Generates CSSOMTypes.cpp and CSSOMKeywords.cpp. These classes provide Generates cssom_types.cc and cssom_keywords.cc. These classes provide
utility methods for determining whether a given CSSStyleValue is valid utility methods for determining whether a given CSSStyleValue is valid
for a given CSS property. The header files live in core/css/cssom. for a given CSS property. The header files live in core/css/cssom.
""" """
...@@ -38,18 +38,18 @@ class CSSOMTypesWriter(json5_generator.Writer): ...@@ -38,18 +38,18 @@ class CSSOMTypesWriter(json5_generator.Writer):
enum_for_css_keyword, property_['keywords']) enum_for_css_keyword, property_['keywords'])
self._outputs = { self._outputs = {
'CSSOMTypes.cpp': self.generate_types, 'cssom_types.cc': self.generate_types,
'CSSOMKeywords.cpp': self.generate_keywords, 'cssom_keywords.cc': self.generate_keywords,
} }
@template_expander.use_jinja('core/css/templates/CSSOMTypes.cpp.tmpl') @template_expander.use_jinja('core/css/templates/cssom_types.cc.tmpl')
def generate_types(self): def generate_types(self):
return { return {
'input_files': self._input_files, 'input_files': self._input_files,
'properties': self._properties, 'properties': self._properties,
} }
@template_expander.use_jinja('core/css/templates/CSSOMKeywords.cpp.tmpl') @template_expander.use_jinja('core/css/templates/cssom_keywords.cc.tmpl')
def generate_keywords(self): def generate_keywords(self):
return { return {
'input_files': self._input_files, 'input_files': self._input_files,
......
...@@ -1163,12 +1163,12 @@ css_properties("make_core_generated_style_builder") { ...@@ -1163,12 +1163,12 @@ css_properties("make_core_generated_style_builder") {
css_properties("make_core_generated_cssom_types") { css_properties("make_core_generated_cssom_types") {
script = "../build/scripts/core/css/make_cssom_types.py" script = "../build/scripts/core/css/make_cssom_types.py"
other_inputs = [ other_inputs = [
"../build/scripts/core/css/templates/CSSOMKeywords.cpp.tmpl", "../build/scripts/core/css/templates/cssom_keywords.cc.tmpl",
"../build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl", "../build/scripts/core/css/templates/cssom_types.cc.tmpl",
] ]
outputs = [ outputs = [
"$blink_core_output_dir/CSSOMKeywords.cpp", "$blink_core_output_dir/cssom_keywords.cc",
"$blink_core_output_dir/CSSOMTypes.cpp", "$blink_core_output_dir/cssom_types.cc",
] ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment