Bookmarks.FileSize histogram should be reported in kilobytes
This CL fixes a bug in reporting the Bookmarks.FileSize metric. base::GetFileSize() return the file size in bytes while KBs are required. Additionally, UMA_HISTOGRAM_MEMORY_KB uses bucketing scheme as follows: The first bucket is for files smaller than 1000K(1MB) and the max bucket is for files larger than 500000KB (500MB) This CL changes the bucketing scheme to better represent small files (smaller than 1000KB) And adjusts the max to be 50MB which is more suitable for bookmarks files. 25 buckets should be enough for analysis. It should be OK to change the bucketing scheme because it didn't hit stable yet. Only canary reporting will be half broken. Bug: 808439 Change-Id: I098f5df128949a9e545dc59973def693ec540ec1 Reviewed-on: https://chromium-review.googlesource.com/931507 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#539536}
Showing
Please register or sign in to comment