Commit 71a48ae3 authored by Fabrice de Gans-Riberi's avatar Fabrice de Gans-Riberi Committed by Commit Bot

[fuchsia] Clean up TODOs in //build/fuchsia

This removes a TODO in amber_repo.py since we are no longer pursuing
checking if "fx serve" is running, considering this is a user error.

Bug: 1104411
Change-Id: I300f61e7b053f27ed6752409899f70f32c061c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427350Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812300}
parent ce9bf93a
...@@ -158,9 +158,6 @@ class ExternalAmberRepo(AmberRepo): ...@@ -158,9 +158,6 @@ class ExternalAmberRepo(AmberRepo):
def __init__(self, amber_root): def __init__(self, amber_root):
self._amber_root = amber_root self._amber_root = amber_root
logging.info('Using existing Amber root: {}'.format(amber_root)) logging.info('Using existing Amber root: {}'.format(amber_root))
# TODO(kmarshall): Find a way to programmatically check if "fx serve" is
# running.
logging.info('Ensure that "fx serve" is running.') logging.info('Ensure that "fx serve" is running.')
def GetPath(self): def GetPath(self):
......
...@@ -10,7 +10,8 @@ from common import SDK_ROOT ...@@ -10,7 +10,8 @@ from common import SDK_ROOT
from common import GetHostArchFromPlatform from common import GetHostArchFromPlatform
from common import GetHostToolPathFromPlatform from common import GetHostToolPathFromPlatform
# TODO(steveroe): Change 'llvm-3.8' to 'llvm' after docker image is updated. # TODO(crbug.com/1131647): Change 'llvm-3.8' to 'llvm' after docker image is
# updated.
ARM64_DOCKER_LLVM_SYMBOLIZER_PATH = os.path.join('/', 'usr', 'lib', 'llvm-3.8', ARM64_DOCKER_LLVM_SYMBOLIZER_PATH = os.path.join('/', 'usr', 'lib', 'llvm-3.8',
'bin', 'llvm-symbolizer') 'bin', 'llvm-symbolizer')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment