Commit 71b5c6a4 authored by Peter E Conn's avatar Peter E Conn Committed by Commit Bot

🤝 Enable Trusted Web Activities on Stable.

This includes two small UX changes - one a word change and one
disabling the persistent notification.

TWAs will still be behind a flag (which is on by default).

Bug: 908052
Change-Id: I3ddb16bc425a437d9fed215e4285c5eba2d20ba0
Reviewed-on: https://chromium-review.googlesource.com/c/1349337Reviewed-by: default avatarMichael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610585}
parent e32020ec
...@@ -4,12 +4,10 @@ ...@@ -4,12 +4,10 @@
package org.chromium.chrome.browser.browserservices.trustedwebactivityui; package org.chromium.chrome.browser.browserservices.trustedwebactivityui;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.PersistentNotificationController;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityDisclosureController; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityDisclosureController;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityOpenTimeRecorder; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityOpenTimeRecorder;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityToolbarController; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityToolbarController;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityVerifier; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.controller.TrustedWebActivityVerifier;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.view.PersistentNotificationView;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.view.TrustedWebActivityDisclosureView; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.view.TrustedWebActivityDisclosureView;
import org.chromium.chrome.browser.browserservices.trustedwebactivityui.view.TrustedWebActivityToolbarView; import org.chromium.chrome.browser.browserservices.trustedwebactivityui.view.TrustedWebActivityToolbarView;
import org.chromium.chrome.browser.customtabs.CloseButtonNavigator; import org.chromium.chrome.browser.customtabs.CloseButtonNavigator;
...@@ -25,12 +23,10 @@ import javax.inject.Inject; ...@@ -25,12 +23,10 @@ import javax.inject.Inject;
public class TrustedWebActivityCoordinator { public class TrustedWebActivityCoordinator {
@Inject @Inject
public TrustedWebActivityCoordinator( public TrustedWebActivityCoordinator(
PersistentNotificationController persistentNotificationController,
TrustedWebActivityDisclosureController disclosureController, TrustedWebActivityDisclosureController disclosureController,
TrustedWebActivityToolbarController toolbarController, TrustedWebActivityToolbarController toolbarController,
TrustedWebActivityToolbarView toolbarView, TrustedWebActivityToolbarView toolbarView,
TrustedWebActivityDisclosureView disclosureView, TrustedWebActivityDisclosureView disclosureView,
PersistentNotificationView notificationView,
TrustedWebActivityOpenTimeRecorder openTimeRecorder, TrustedWebActivityOpenTimeRecorder openTimeRecorder,
TrustedWebActivityVerifier verifier, TrustedWebActivityVerifier verifier,
CloseButtonNavigator closeButtonNavigator) { CloseButtonNavigator closeButtonNavigator) {
......
...@@ -85,7 +85,7 @@ public class TrustedWebActivityDisclosureView implements ...@@ -85,7 +85,7 @@ public class TrustedWebActivityDisclosureView implements
int type = Snackbar.TYPE_PERSISTENT; int type = Snackbar.TYPE_PERSISTENT;
int code = Snackbar.UMA_TWA_PRIVACY_DISCLOSURE; int code = Snackbar.UMA_TWA_PRIVACY_DISCLOSURE;
String action = mResources.getString(R.string.ok_got_it); String action = mResources.getString(R.string.ok);
return Snackbar.make(title, mSnackbarController, type, code) return Snackbar.make(title, mSnackbarController, type, code)
.setAction(action, null) .setAction(action, null)
.setSingleLine(false); .setSingleLine(false);
......
...@@ -773,7 +773,6 @@ public class CustomTabIntentDataProvider extends BrowserSessionDataProvider { ...@@ -773,7 +773,6 @@ public class CustomTabIntentDataProvider extends BrowserSessionDataProvider {
boolean isTrustedWebActivity() { boolean isTrustedWebActivity() {
if (!ChromeFeatureList.isInitialized()) return false; if (!ChromeFeatureList.isInitialized()) return false;
if (!ChromeFeatureList.isEnabled(ChromeFeatureList.TRUSTED_WEB_ACTIVITY)) return false; if (!ChromeFeatureList.isEnabled(ChromeFeatureList.TRUSTED_WEB_ACTIVITY)) return false;
if (ChromeVersionInfo.isBetaBuild() || ChromeVersionInfo.isStableBuild()) return false;
return mIsTrustedWebActivity; return mIsTrustedWebActivity;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment