Commit 71c74265 authored by Daniel Cheng's avatar Daniel Cheng Committed by Commit Bot

Pass more things by const ref in SmartClip

Change-Id: I679eafa7719553792404d3c0549b5a7877d34c86
Reviewed-on: https://chromium-review.googlesource.com/791513Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520778}
parent f3a5b8c1
...@@ -59,14 +59,6 @@ static Node* NodeInsideFrame(Node* node) { ...@@ -59,14 +59,6 @@ static Node* NodeInsideFrame(Node* node) {
return nullptr; return nullptr;
} }
IntRect SmartClipData::RectInViewport() const {
return rect_in_viewport_;
}
const String& SmartClipData::ClipData() const {
return string_;
}
SmartClip::SmartClip(LocalFrame* frame) : frame_(frame) {} SmartClip::SmartClip(LocalFrame* frame) : frame_(frame) {}
SmartClipData SmartClip::DataForRect(const IntRect& crop_rect_in_viewport) { SmartClipData SmartClip::DataForRect(const IntRect& crop_rect_in_viewport) {
......
...@@ -44,11 +44,11 @@ class CORE_EXPORT SmartClipData { ...@@ -44,11 +44,11 @@ class CORE_EXPORT SmartClipData {
public: public:
SmartClipData() {} SmartClipData() {}
SmartClipData(IntRect rect, String string) SmartClipData(const IntRect& rect, const String& string)
: rect_in_viewport_(rect), string_(string) {} : rect_in_viewport_(rect), string_(string) {}
IntRect RectInViewport() const; const IntRect& RectInViewport() const { return rect_in_viewport_; }
const String& ClipData() const; const String& ClipData() const { return string_; }
private: private:
IntRect rect_in_viewport_; IntRect rect_in_viewport_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment