Commit 71d515f0 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/media/webrtc/webrtc_event_log_manager_common_unittest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=eladalon@chromium.org

Bug: 925652
Change-Id: I9e896043df954dc48b883eb78b1f0bbe6ab97558
Reviewed-on: https://chromium-review.googlesource.com/c/1437832
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: default avatarElad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626472}
parent a7b8f98b
...@@ -466,7 +466,7 @@ TEST_P(LogFileWriterTest, PathReturnsTheCorrectPath) { ...@@ -466,7 +466,7 @@ TEST_P(LogFileWriterTest, PathReturnsTheCorrectPath) {
ASSERT_EQ(writer->path(), path_); ASSERT_EQ(writer->path(), path_);
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
Compression, Compression,
LogFileWriterTest, LogFileWriterTest,
::testing::Values(WebRtcEventLogCompression::NONE, ::testing::Values(WebRtcEventLogCompression::NONE,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment