Commit 71df64db authored by chaopeng's avatar chaopeng Committed by Commit Bot

Fix DirectManipulationBrowserTest.HWNDReparent in Debug bots

The test failed in debug bots because we direct reparent the HWND to
another shell and skip full window reparent logic then shell close also
overwrite some state.

In this patch, we moved shell close to the end of test body.

Bug: 833661
Change-Id: I06c639a1c1620fe3a06af2eb6606970a6a86c78c
Reviewed-on: https://chromium-review.googlesource.com/1025119Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553259}
parent a6508c56
...@@ -113,10 +113,10 @@ IN_PROC_BROWSER_TEST_P(DirectManipulationBrowserTest, HWNDReparent) { ...@@ -113,10 +113,10 @@ IN_PROC_BROWSER_TEST_P(DirectManipulationBrowserTest, HWNDReparent) {
UpdateParent( UpdateParent(
shell2->window()->GetRootWindow()->GetHost()->GetAcceleratedWidget()); shell2->window()->GetRootWindow()->GetHost()->GetAcceleratedWidget());
shell()->Close();
// The animation observer should be removed. // The animation observer should be removed.
EXPECT_FALSE(HasCompositorAnimationObserver(lrwhh)); EXPECT_FALSE(HasCompositorAnimationObserver(lrwhh));
shell2->Close();
} }
// EventLogger is to obserser the events sent from WindowEventTarget (the root // EventLogger is to obserser the events sent from WindowEventTarget (the root
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment