Commit 71e0babe authored by bsy@google.com's avatar bsy@google.com

reduce log verbosity level

Some NaClLog invocations were left with detail level 0, which gets
printed by default.  This CL just increases some of these, so that
NACLVERBOSITY environment variable would have to be set to see events
such as NaCl module crash log messages that occur while generating the
'crashed' event.

BUG= None
TEST= None


Review URL: http://codereview.chromium.org/8929022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114585 0039d316-1c4b-4281-b951-d872f2087c98
parent 46d50ead
......@@ -1274,6 +1274,15 @@ void Plugin::NexeDidCrash(int32_t pp_error) {
" non-PP_OK arg -- SHOULD NOT HAPPEN\n"));
}
PLUGIN_PRINTF(("Plugin::NexeDidCrash: crash event!\n"));
int exit_status = main_subprocess_.service_runtime()->exit_status();
if (-1 != exit_status) {
// The NaCl module voluntarily exited. However, this is still a
// crash from the point of view of Pepper, since PPAPI plugins are
// event handlers and should never exit.
PLUGIN_PRINTF((("Plugin::NexeDidCrash: nexe exited with status %d"
" so this is a \"controlled crash\".\n"),
exit_status));
}
// If the crash occurs during load, we just want to report an error
// that fits into our load progress event grammar. If the crash
// occurs after loaded/loadend, then we use ReportDeadNexe to send a
......
......@@ -121,14 +121,14 @@ void PluginReverseInterface::DoPostMessage(nacl::string message) {
}
void PluginReverseInterface::StartupInitializationComplete() {
NaClLog(0, "PluginReverseInterface::StartupInitializationComplete\n");
NaClLog(4, "PluginReverseInterface::StartupInitializationComplete\n");
if (init_done_cb_.pp_completion_callback().func != NULL) {
NaClLog(0,
NaClLog(4,
"PluginReverseInterface::StartupInitializationComplete:"
" invoking CB\n");
pp::Module::Get()->core()->CallOnMainThread(0, init_done_cb_, PP_OK);
} else {
NaClLog(0,
NaClLog(1,
"PluginReverseInterface::StartupInitializationComplete:"
" init_done_cb_ not valid, skipping.\n");
}
......@@ -362,12 +362,12 @@ void PluginReverseInterface::CloseManifestEntry_MainThreadContinuation(
}
void PluginReverseInterface::ReportCrash() {
NaClLog(0, "PluginReverseInterface::ReportCrash\n");
NaClLog(4, "PluginReverseInterface::ReportCrash\n");
if (crash_cb_.pp_completion_callback().func != NULL) {
NaClLog(0, "PluginReverseInterface::ReportCrash: invoking CB\n");
NaClLog(4, "PluginReverseInterface::ReportCrash: invoking CB\n");
pp::Module::Get()->core()->CallOnMainThread(0, crash_cb_, PP_OK);
} else {
NaClLog(0,
NaClLog(1,
"PluginReverseInterface::ReportCrash:"
" crash_cb_ not valid, skipping\n");
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment