Commit 7200327a authored by Fergus Dall's avatar Fergus Dall Committed by Commit Bot

Revert "vk: Fix virtual keyboard in guest mode."

This reverts commit 75c556a2.

Reason for revert: Broke the build. See https://ci.chromium.org/p/chrome/builders/ci/linux-builder-perf/112471

Original change's description:
> vk: Fix virtual keyboard in guest mode.
> 
> When crrev/1787601 landed, it removed some code that actually had a
> side effect that caused the virtual keyboard to work correctly in
> guest mode. Without the code, the virtual keyboard doesn't work anymore
> so we are adding this code back temporarily as it is a high priority
> issue.
> 
> We need to investigate how things are meant to work (and how it managed
> to work prior to the filesystems code).
> 
> TBR=benwells,rhalavati,mek
> 
> Bug: 1005083
> Change-Id: I0b393aa518299f5630582deb64f88d82e02ec0e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809033
> Reviewed-by: Darren Shen <shend@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#697917}

TBR=benwells@chromium.org,mek@chromium.org,shend@chromium.org,rhalavati@chromium.org

Change-Id: Ibce04c0db78b166fb7efd1a1149b7b272f172785
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810152Reviewed-by: default avatarFergus Dall <sidereal@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#697921}
parent 832b3ae6
......@@ -576,13 +576,6 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
Add(IDR_CRYPTOTOKEN_MANIFEST,
base::FilePath(FILE_PATH_LITERAL("cryptotoken")));
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
// TODO(https://crbug.com/1005083): Force the off the record profile to be
// created to allow the virtual keyboard to work in guest mode.
if (!IsNormalSession())
ExtensionsBrowserClient::Get()->GetOffTheRecordContext(profile_);
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
}
void ComponentLoader::
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment