Skip to content

GitLab

T
tangled
Commit 7201d58c authored by morrita@chromium.org's avatar morrita@chromium.org
Browse files
Options

Rewrite rel-import-to-style.html to kill the flakiness. 

BUG=370490
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/278643002

git-svn-id: svn://svn.chromium.org/blink/trunk@173668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 55783f9a
Hide whitespace changes
Inline Side-by-side
Showing with 19 additions and 22 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 7201d58c
...@@ -1265,8 +1265,6 @@ crbug.com/361729 fast/multicol/pagination-h-horizontal-tb.html [ Pass Failure ] ...@@ -1265,8 +1265,6 @@ crbug.com/361729 fast/multicol/pagination-h-horizontal-tb.html [ Pass Failure ]
# Started failing with v8 roll in chromium r267851. # Started failing with v8 roll in chromium r267851.
crbug.com/369600 fast/events/onerror-no-constructor.html [ Failure ] crbug.com/369600 fast/events/onerror-no-constructor.html [ Failure ]
crbug.com/370490 fast/html/imports/rel-import-to-style.html [ Pass Failure ]
crbug.com/370789 fast/dom/document-contentType-data-uri.html [ Failure ] crbug.com/370789 fast/dom/document-contentType-data-uri.html [ Failure ]
crbug.com/370906 fast/dom/StyleSheet/gc-declaration-parent-rule.html [ Failure ] crbug.com/370906 fast/dom/StyleSheet/gc-declaration-parent-rule.html [ Failure ]
......
third_party/WebKit/LayoutTests/fast/html/imports/rel-import-to-style-expected.txt
View file @ 7201d58c
Updating attribute value shouldn't invalidate loaded import. Updating attribute value shouldn't invalidate loaded import.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Before update: Before update:
PASS target.sheet is null PASS target.sheet is null
PASS target.import is non-null. PASS target.import is non-null.
......
third_party/WebKit/LayoutTests/fast/html/imports/rel-import-to-style.html
View file @ 7201d58c
...@@ -7,27 +7,22 @@ ...@@ -7,27 +7,22 @@
</head> </head>
<body> <body>
<script> <script>
waitAndTest([ window.jsTestIsAsync = true;
{ description('Updating attribute value shouldn\'t invalidate loaded import.');
description: "Updating attribute value shouldn't invalidate loaded import.", (function() {
setup: function() debug('Before update:');
{ shouldBeNull('target.sheet');
debug("Before update:"); shouldBeNonNull('target.import');
shouldBeNull("target.sheet"); target.setAttribute('href', 'resources/hello.css');
shouldBeNonNull("target.import"); target.setAttribute('rel', 'stylesheet');
target.setAttribute("href", "resources/hello.css"); window.placeholder = createPlaceholder();
target.setAttribute("rel", "stylesheet"); window.placeholder.onload = function() {
window.placeholder = createPlaceholder(); debug('After update:');
}, shouldBeNull('target.sheet');
ready: function() { return window.placeholder.import; }, shouldBeNonNull('target.import');
test: function() window.addEventListener('load', function() { requestAnimationFrame(finishJSTest); });
{
debug("After update:");
shouldBeNull("target.sheet");
shouldBeNonNull("target.import");
}
} }
]); })();
</script> </script>
</body> </body>
</html> </html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment