Commit 721c5bde authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[Passwords] Fix browser_tests for leak check

https://crrev.com/c/2087623 wasn't rebased properly which caused
browser_test failures. This CL uses the new testing helpers which
fixes these issues.

Bug: 1047726
Change-Id: If1cccf27566019753b200e63966e2d756f40d745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093442Reviewed-by: default avatarKamila Hasanbega <hkamila@chromium.org>
Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749187}
parent a80ba084
...@@ -649,7 +649,7 @@ cr.define('settings_passwords_check', function() { ...@@ -649,7 +649,7 @@ cr.define('settings_passwords_check', function() {
test('testShowsPositiveBannerWhenIdle', function() { test('testShowsPositiveBannerWhenIdle', function() {
const data = passwordManager.data; const data = passwordManager.data;
assertEquals(PasswordCheckState.IDLE, data.checkStatus.state); assertEquals(PasswordCheckState.IDLE, data.checkStatus.state);
assertEquals(0, data.leakedCredentials.compromisedCredentials.length); assertEquals(0, data.leakedCredentials.length);
const checkPasswordSection = createCheckPasswordSection(); const checkPasswordSection = createCheckPasswordSection();
return passwordManager.whenCalled('getPasswordCheckStatus').then(() => { return passwordManager.whenCalled('getPasswordCheckStatus').then(() => {
...@@ -665,7 +665,7 @@ cr.define('settings_passwords_check', function() { ...@@ -665,7 +665,7 @@ cr.define('settings_passwords_check', function() {
// in progress but hasn't found anything yet. // in progress but hasn't found anything yet.
test('testShowsNeutralBannerWhenRunning', function() { test('testShowsNeutralBannerWhenRunning', function() {
const data = passwordManager.data; const data = passwordManager.data;
assertEquals(0, data.leakedCredentials.compromisedCredentials.length); assertEquals(0, data.leakedCredentials.length);
data.checkStatus = autofill_test_util.makePasswordCheckStatus( data.checkStatus = autofill_test_util.makePasswordCheckStatus(
/*state=*/ PasswordCheckState.RUNNING, /*checked=*/ 1, /*state=*/ PasswordCheckState.RUNNING, /*checked=*/ 1,
/*remaining=*/ 5); /*remaining=*/ 5);
...@@ -684,7 +684,7 @@ cr.define('settings_passwords_check', function() { ...@@ -684,7 +684,7 @@ cr.define('settings_passwords_check', function() {
// in progress but hasn't found anything yet. // in progress but hasn't found anything yet.
test('testShowsNeutralBannerWhenCanceled', function() { test('testShowsNeutralBannerWhenCanceled', function() {
const data = passwordManager.data; const data = passwordManager.data;
assertEquals(0, data.leakedCredentials.compromisedCredentials.length); assertEquals(0, data.leakedCredentials.length);
data.checkStatus = autofill_test_util.makePasswordCheckStatus( data.checkStatus = autofill_test_util.makePasswordCheckStatus(
/*state=*/ PasswordCheckState.CANCELED); /*state=*/ PasswordCheckState.CANCELED);
...@@ -704,13 +704,10 @@ cr.define('settings_passwords_check', function() { ...@@ -704,13 +704,10 @@ cr.define('settings_passwords_check', function() {
data.checkStatus = autofill_test_util.makePasswordCheckStatus( data.checkStatus = autofill_test_util.makePasswordCheckStatus(
/*state=*/ PasswordCheckState.RUNNING, /*checked=*/ 1, /*state=*/ PasswordCheckState.RUNNING, /*checked=*/ 1,
/*remaining=*/ 5); /*remaining=*/ 5);
data.leakedCredentials = data.leakedCredentials = [
autofill_test_util.makeCompromisedCredentialsInfo( autofill_test_util.makeCompromisedCredential(
[ 'one.com', 'test4', 'LEAKED'),
autofill_test_util.makeCompromisedCredentials( ];
'one.com', 'test4', 'LEAKED'),
],
'just now');
const checkPasswordSection = createCheckPasswordSection(); const checkPasswordSection = createCheckPasswordSection();
return passwordManager.whenCalled('getPasswordCheckStatus').then(() => { return passwordManager.whenCalled('getPasswordCheckStatus').then(() => {
...@@ -724,13 +721,10 @@ cr.define('settings_passwords_check', function() { ...@@ -724,13 +721,10 @@ cr.define('settings_passwords_check', function() {
const data = passwordManager.data; const data = passwordManager.data;
data.checkStatus = autofill_test_util.makePasswordCheckStatus( data.checkStatus = autofill_test_util.makePasswordCheckStatus(
/*state=*/ PasswordCheckState.IDLE); /*state=*/ PasswordCheckState.IDLE);
data.leakedCredentials = data.leakedCredentials = [
autofill_test_util.makeCompromisedCredentialsInfo( autofill_test_util.makeCompromisedCredential(
[ 'one.com', 'test4', 'LEAKED'),
autofill_test_util.makeCompromisedCredentials( ];
'one.com', 'test4', 'LEAKED'),
],
'Just now');
const checkPasswordSection = createCheckPasswordSection(); const checkPasswordSection = createCheckPasswordSection();
return passwordManager.whenCalled('getPasswordCheckStatus').then(() => { return passwordManager.whenCalled('getPasswordCheckStatus').then(() => {
...@@ -744,13 +738,10 @@ cr.define('settings_passwords_check', function() { ...@@ -744,13 +738,10 @@ cr.define('settings_passwords_check', function() {
const data = passwordManager.data; const data = passwordManager.data;
data.checkStatus = autofill_test_util.makePasswordCheckStatus( data.checkStatus = autofill_test_util.makePasswordCheckStatus(
/*state=*/ PasswordCheckState.CANCELED); /*state=*/ PasswordCheckState.CANCELED);
data.leakedCredentials = data.leakedCredentials = [
autofill_test_util.makeCompromisedCredentialsInfo( autofill_test_util.makeCompromisedCredential(
[ 'one.com', 'test4', 'LEAKED'),
autofill_test_util.makeCompromisedCredentials( ];
'one.com', 'test4', 'LEAKED'),
],
'Just now');
const checkPasswordSection = createCheckPasswordSection(); const checkPasswordSection = createCheckPasswordSection();
return passwordManager.whenCalled('getPasswordCheckStatus').then(() => { return passwordManager.whenCalled('getPasswordCheckStatus').then(() => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment