Commit 723e06ee authored by Robbie Gibson's avatar Robbie Gibson Committed by Commit Bot

[iOS] Fix incorrect flag name for OmniboxOnFocusSuggestions

Because the name was incorrect here, when Finch sends a config for this
Feature, both the gws_id from Finch and the gws_id defined in
about_flags were sent back to gws. If an enabled and a disabled ID are
sent to gws, the disabled id is the one that takes affect, so the
feature ends up disabled.

Bug: 1071078
Change-Id: Ic67f1d5415ac5895a84ee41adc8b2c98d1c38456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153106Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#759983}
parent 04dab5a9
...@@ -382,7 +382,7 @@ const flags_ui::FeatureEntry kFeatureEntries[] = { ...@@ -382,7 +382,7 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flag_descriptions::kOmniboxOnFocusSuggestionsDescription, flags_ui::kOsIos, flag_descriptions::kOmniboxOnFocusSuggestionsDescription, flags_ui::kOsIos,
FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kOnFocusSuggestions, FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kOnFocusSuggestions,
kOmniboxOnFocusSuggestionsVariations, kOmniboxOnFocusSuggestionsVariations,
"OmniboxBundledExperimentV1")}, "OmniboxOnFocusSuggestions")},
{"omnibox-ui-max-autocomplete-matches", {"omnibox-ui-max-autocomplete-matches",
flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName, flag_descriptions::kOmniboxUIMaxAutocompleteMatchesName,
flag_descriptions::kOmniboxUIMaxAutocompleteMatchesDescription, flag_descriptions::kOmniboxUIMaxAutocompleteMatchesDescription,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment