Commit 724697cd authored by Mounir Lamouri's avatar Mounir Lamouri Committed by Commit Bot

WebAudio: some checks around GetDocument() calls.

Adding a DCHECK() and a null check.

Bug: 883329
Change-Id: I56efb844c7cc6788ac04e9f494608ef18e94cd78
Reviewed-on: https://chromium-review.googlesource.com/1236454Reviewed-by: default avatarHongchan Choi <hongchan@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592817}
parent d0ffabb7
...@@ -361,13 +361,14 @@ AutoplayPolicy::Type AudioContext::GetAutoplayPolicy() const { ...@@ -361,13 +361,14 @@ AutoplayPolicy::Type AudioContext::GetAutoplayPolicy() const {
} }
bool AudioContext::AreAutoplayRequirementsFulfilled() const { bool AudioContext::AreAutoplayRequirementsFulfilled() const {
DCHECK(GetDocument());
switch (GetAutoplayPolicy()) { switch (GetAutoplayPolicy()) {
case AutoplayPolicy::Type::kNoUserGestureRequired: case AutoplayPolicy::Type::kNoUserGestureRequired:
return true; return true;
case AutoplayPolicy::Type::kUserGestureRequired: case AutoplayPolicy::Type::kUserGestureRequired:
case AutoplayPolicy::Type::kUserGestureRequiredForCrossOrigin: case AutoplayPolicy::Type::kUserGestureRequiredForCrossOrigin:
return Frame::HasTransientUserActivation( return Frame::HasTransientUserActivation(GetDocument()->GetFrame());
GetDocument() ? GetDocument()->GetFrame() : nullptr);
case AutoplayPolicy::Type::kDocumentUserActivationRequired: case AutoplayPolicy::Type::kDocumentUserActivationRequired:
return AutoplayPolicy::IsDocumentAllowedToPlay(*GetDocument()); return AutoplayPolicy::IsDocumentAllowedToPlay(*GetDocument());
} }
...@@ -422,7 +423,7 @@ bool AudioContext::IsAllowedToStart() const { ...@@ -422,7 +423,7 @@ bool AudioContext::IsAllowedToStart() const {
} }
void AudioContext::RecordAutoplayMetrics() { void AudioContext::RecordAutoplayMetrics() {
if (!autoplay_status_.has_value()) if (!autoplay_status_.has_value() || !GetDocument())
return; return;
ukm::UkmRecorder* ukm_recorder = GetDocument()->UkmRecorder(); ukm::UkmRecorder* ukm_recorder = GetDocument()->UkmRecorder();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment