Commit 7248878f authored by Gang Wu's avatar Gang Wu Committed by Commit Bot

[Feed] destroy image loader after destroy StreamLifecycleManager

Should call image loader's destroy after StreamLifecycleManager::destroy
to avoid race condition, since StreamLifecycleManager may ask image
loader between FeedImageLoader::destroy and
StreamLifecycleManager::destroy.

Change-Id: Ib291ef3716e118c2ba66ffe1e26165f259bcfeaf
Reviewed-on: https://chromium-review.googlesource.com/c/1260008Reviewed-by: default avatarSky Malice <skym@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596440}
parent 86f55d21
......@@ -256,8 +256,8 @@ public class FeedNewTabPage extends NewTabPage {
public void destroy() {
super.destroy();
mMediator.destroy();
if (mImageLoader != null) mImageLoader.destroy();
if (mStreamLifecycleManager != null) mStreamLifecycleManager.destroy();
if (mImageLoader != null) mImageLoader.destroy();
mTab.getWindowAndroid().removeContextMenuCloseListener(mContextMenuManager);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment