Commit 724af495 authored by Tommy Steimel's avatar Tommy Steimel Committed by Commit Bot

GMC: Reland 'Replace is_controllable DCHECK with if condition'

This CL relands a fix for a broken DCHECK in the
MediaToolbarButtonController. This fix was accidentally removed by a
bad rebase in a different CL.

Bug: 973486
Change-Id: Idb8cb0a8ceb251c82a81203ac2ef37ebc90fbf50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695928Reviewed-by: default avatarBecca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676176}
parent 59118d9f
...@@ -39,11 +39,6 @@ MediaToolbarButtonController::~MediaToolbarButtonController() = default; ...@@ -39,11 +39,6 @@ MediaToolbarButtonController::~MediaToolbarButtonController() = default;
void MediaToolbarButtonController::MediaSessionInfoChanged( void MediaToolbarButtonController::MediaSessionInfoChanged(
media_session::mojom::MediaSessionInfoPtr session_info) { media_session::mojom::MediaSessionInfoPtr session_info) {
if (session_info) { if (session_info && session_info->is_controllable)
// We only want to show if there's a controllable media session. However, as
// a MediaControllerObserver we should only receive a
// |MediaSessionInfoChanged()| call for a controllable session.
DCHECK(session_info->is_controllable);
delegate_->Show(); delegate_->Show();
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment