Commit 725362cf authored by Jing Wang's avatar Jing Wang Committed by Commit Bot

Change flags for assistive personal types to enable by default.

It is problematic for testing during development if these flags are
disabled by default. And it's safe to enable them by default, since
the flag AssistPersonalInfo, which is the main switch for these
features, are disabled by default.

Bug: 1042084
Change-Id: Iad61804c53d306df5378844d8770e98bdbe96f1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415751Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Reviewed-by: default avatarMy Nguyen <myy@chromium.org>
Commit-Queue: Jing Wang <jiwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#808138}
parent 287195d2
...@@ -80,22 +80,22 @@ const base::Feature kAssistPersonalInfo{"AssistPersonalInfo", ...@@ -80,22 +80,22 @@ const base::Feature kAssistPersonalInfo{"AssistPersonalInfo",
// Controls whether to suggest addresses in assistive personal information. This // Controls whether to suggest addresses in assistive personal information. This
// is only effective when AssistPersonalInfo flag is enabled. // is only effective when AssistPersonalInfo flag is enabled.
const base::Feature kAssistPersonalInfoAddress{ const base::Feature kAssistPersonalInfoAddress{
"AssistPersonalInfoAddress", base::FEATURE_DISABLED_BY_DEFAULT}; "AssistPersonalInfoAddress", base::FEATURE_ENABLED_BY_DEFAULT};
// Controls whether to suggest emails in assistive personal information. This is // Controls whether to suggest emails in assistive personal information. This is
// only effective when AssistPersonalInfo flag is enabled. // only effective when AssistPersonalInfo flag is enabled.
const base::Feature kAssistPersonalInfoEmail{"AssistPersonalInfoEmail", const base::Feature kAssistPersonalInfoEmail{"AssistPersonalInfoEmail",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Controls whether to suggest names in assistive personal information. This is // Controls whether to suggest names in assistive personal information. This is
// only effective when AssistPersonalInfo flag is enabled. // only effective when AssistPersonalInfo flag is enabled.
const base::Feature kAssistPersonalInfoName{"AssistPersonalInfoName", const base::Feature kAssistPersonalInfoName{"AssistPersonalInfoName",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Controls whether to suggest phone numbers in assistive personal information. // Controls whether to suggest phone numbers in assistive personal information.
// This is only effective when AssistPersonalInfo flag is enabled. // This is only effective when AssistPersonalInfo flag is enabled.
const base::Feature kAssistPersonalInfoPhoneNumber{ const base::Feature kAssistPersonalInfoPhoneNumber{
"AssistPersonalInfoPhoneNumber", base::FEATURE_DISABLED_BY_DEFAULT}; "AssistPersonalInfoPhoneNumber", base::FEATURE_ENABLED_BY_DEFAULT};
// Displays the avatar toolbar button and the profile menu. // Displays the avatar toolbar button and the profile menu.
// https://crbug.com/1041472 // https://crbug.com/1041472
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment