Commit 725926d9 authored by thakis@chromium.org's avatar thakis@chromium.org

android envsetup: Stop exporting ANDROID_NDK_ROOT.

Change its only user, adb_gdb, to instead use pylib.constants.

BUG=330631
NOTRY=true

Review URL: https://codereview.chromium.org/221933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261437 0039d316-1c4b-4281-b951-d872f2087c98
parent ba410a3c
...@@ -245,12 +245,7 @@ them up automatically for you though: ...@@ -245,12 +245,7 @@ them up automatically for you though:
- host gdb client (e.g. arm-linux-androideabi-gdb) - host gdb client (e.g. arm-linux-androideabi-gdb)
- directory with symbolic version of $PROGRAM_NAME's shared libraries. - directory with symbolic version of $PROGRAM_NAME's shared libraries.
If you have sourced Chromium's build/android/envsetup.sh, this script will You can also use --ndk-dir=<path> to specify an alternative NDK installation
find all of them automatically. This is the recommended way to use it.
Otherwise, if you have ANDROID_NDK_ROOT defined in your environment,
the script will use it to find the gdb and gdbserver binaries. You can
also use --ndk-dir=<path> to specify an alternative NDK installation
directory. directory.
The script tries to find the most recent version of the debug version of The script tries to find the most recent version of the debug version of
...@@ -342,10 +337,8 @@ if [ -z "$PACKAGE_NAME" ]; then ...@@ -342,10 +337,8 @@ if [ -z "$PACKAGE_NAME" ]; then
fi fi
if [ -z "$NDK_DIR" ]; then if [ -z "$NDK_DIR" ]; then
if [ -z "$ANDROID_NDK_ROOT" ]; then ANDROID_NDK_ROOT=$(PYTHONPATH=build/android python -c \
panic "Can't find NDK directory, please source \ 'from pylib.constants import ANDROID_NDK_ROOT; print ANDROID_NDK_ROOT,')
build/android/envsetup.sh!"
fi
else else
if [ ! -d "$NDK_DIR" ]; then if [ ! -d "$NDK_DIR" ]; then
panic "Invalid directory: $NDK_DIR" panic "Invalid directory: $NDK_DIR"
......
...@@ -33,9 +33,6 @@ fi ...@@ -33,9 +33,6 @@ fi
# Allow the caller to override a few environment variables. If any of them is # Allow the caller to override a few environment variables. If any of them is
# unset, we default to a sane value that's known to work. This allows for # unset, we default to a sane value that's known to work. This allows for
# experimentation with a custom SDK. # experimentation with a custom SDK.
if [[ -z "${ANDROID_NDK_ROOT}" || ! -d "${ANDROID_NDK_ROOT}" ]]; then
export ANDROID_NDK_ROOT="${CHROME_SRC}/third_party/android_tools/ndk/"
fi
if [[ -z "${ANDROID_SDK_ROOT}" || ! -d "${ANDROID_SDK_ROOT}" ]]; then if [[ -z "${ANDROID_SDK_ROOT}" || ! -d "${ANDROID_SDK_ROOT}" ]]; then
export ANDROID_SDK_ROOT="${CHROME_SRC}/third_party/android_tools/sdk/" export ANDROID_SDK_ROOT="${CHROME_SRC}/third_party/android_tools/sdk/"
fi fi
......
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
"""Provides an interface to start and stop Android emulator. """Provides an interface to start and stop Android emulator.
Assumes system environment ANDROID_NDK_ROOT has been set.
Emulator: The class provides the methods to launch/shutdown the emulator with Emulator: The class provides the methods to launch/shutdown the emulator with
the android virtual device named 'avd_armeabi' . the android virtual device named 'avd_armeabi' .
""" """
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment