2011-03-14 Geoffrey Garen <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Made the global object moving-GC-safe
        https://bugs.webkit.org/show_bug.cgi?id=56348
        
        SunSpider reports no change.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren): Removed a dubious comment that
        suggested we do not need to visit all our references during GC, since
        that is not true in a moving GC.

        Re-sorted data members by type, removed one duplicate, and added back
        the one missing mark I found.

        * runtime/JSGlobalObject.h: Re-sorted data members by type.


git-svn-id: svn://svn.chromium.org/blink/trunk@81100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/JavaScriptCore/ChangeLog

+2011-03-14  Geoffrey Garen  <ggaren@apple.com>
+
+        Reviewed by Oliver Hunt.
+
+        Made the global object moving-GC-safe
+        https://bugs.webkit.org/show_bug.cgi?id=56348
+        
+        SunSpider reports no change.
+
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::markChildren): Removed a dubious comment that
+        suggested we do not need to visit all our references during GC, since
+        that is not true in a moving GC.
+
+        Re-sorted data members by type, removed one duplicate, and added back
+        the one missing mark I found.
+
+        * runtime/JSGlobalObject.h: Re-sorted data members by type.
+
 2011-03-14  Geoffrey Garen  <ggaren@apple.com>
 
         Reviewed by Oliver Hunt.

third_party/WebKit/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -316,8 +316,9 @@ void JSGlobalObject::resetPrototype(JSValue prototype)
 void JSGlobalObject::markChildren(MarkStack& markStack)
 {
     JSVariableObject::markChildren(markStack);
-    
+
     markIfNeeded(markStack, &m_globalScopeChain);
+    markIfNeeded(markStack, &m_methodCallDummy);
 
     markIfNeeded(markStack, &m_regExpConstructor);
     markIfNeeded(markStack, &m_errorConstructor);
@@ -341,9 +342,6 @@ void JSGlobalObject::markChildren(MarkStack& markStack)
     markIfNeeded(markStack, &m_datePrototype);
     markIfNeeded(markStack, &m_regExpPrototype);
 
-    markIfNeeded(markStack, &m_methodCallDummy);
-
-    markIfNeeded(markStack, m_errorStructure);
     markIfNeeded(markStack, m_argumentsStructure);
     markIfNeeded(markStack, m_arrayStructure);
     markIfNeeded(markStack, m_booleanObjectStructure);
@@ -358,9 +356,7 @@ void JSGlobalObject::markChildren(MarkStack& markStack)
     markIfNeeded(markStack, m_regExpMatchesArrayStructure);
     markIfNeeded(markStack, m_regExpStructure);
     markIfNeeded(markStack, m_stringObjectStructure);
-
-    // No need to mark the other structures, because their prototypes are all
-    // guaranteed to be referenced elsewhere.
+    markIfNeeded(markStack, m_internalFunctionStructure);
 
     if (m_registerArray) {
         // Outside the execution of global code, when our variables are torn off,

third_party/WebKit/Source/JavaScriptCore/runtime/JSGlobalObject.h

@@ -56,15 +56,13 @@ namespace JSC {
     protected:
         typedef HashSet<RefPtr<OpaqueJSWeakObjectMap> > WeakMapSet;
 
-        size_t m_registerArraySize;
+        RefPtr<JSGlobalData> m_globalData;
 
-        JSGlobalObject* m_next;
-        JSGlobalObject* m_prev;
+        size_t m_registerArraySize;
+        Register m_globalCallFrame[RegisterFile::CallFrameHeaderSize];
 
-        Debugger* m_debugger;
-        
         WriteBarrier<ScopeChainNode> m_globalScopeChain;
-        Register m_globalCallFrame[RegisterFile::CallFrameHeaderSize];
+        WriteBarrier<JSObject> m_methodCallDummy;
 
         WriteBarrier<RegExpConstructor> m_regExpConstructor;
         WriteBarrier<ErrorConstructor> m_errorConstructor;
@@ -88,8 +86,6 @@ namespace JSC {
         WriteBarrier<DatePrototype> m_datePrototype;
         WriteBarrier<RegExpPrototype> m_regExpPrototype;
 
-        WriteBarrier<JSObject> m_methodCallDummy;
-
         RefPtr<Structure> m_argumentsStructure;
         RefPtr<Structure> m_arrayStructure;
         RefPtr<Structure> m_booleanObjectStructure;
@@ -106,14 +102,14 @@ namespace JSC {
         RefPtr<Structure> m_stringObjectStructure;
         RefPtr<Structure> m_internalFunctionStructure;
 
-        SymbolTable m_symbolTable;
         unsigned m_profileGroup;
-
-        RefPtr<JSGlobalData> m_globalData;
+        Debugger* m_debugger;
 
         WeakMapSet m_weakMaps;
         WeakRandom m_weakRandom;
 
+        SymbolTable m_symbolTable;
+
     public:
         void* operator new(size_t, JSGlobalData*);