Commit 727cae88 authored by Erik Corry's avatar Erik Corry

Let --js-flags work when Harmony is enabled in about:flags

R=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/588543003

Cr-Commit-Position: refs/heads/master@{#295960}
parent 09e1192d
...@@ -806,7 +806,7 @@ const Experiment kExperiments[] = { ...@@ -806,7 +806,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ENABLE_JAVASCRIPT_HARMONY_NAME, IDS_FLAGS_ENABLE_JAVASCRIPT_HARMONY_NAME,
IDS_FLAGS_ENABLE_JAVASCRIPT_HARMONY_DESCRIPTION, IDS_FLAGS_ENABLE_JAVASCRIPT_HARMONY_DESCRIPTION,
kOsAll, kOsAll,
SINGLE_VALUE_TYPE_AND_VALUE(switches::kJavaScriptFlags, "--harmony") SINGLE_VALUE_TYPE(switches::kJavaScriptHarmony)
}, },
{ {
"disable-software-rasterizer", "disable-software-rasterizer",
......
...@@ -1359,6 +1359,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches( ...@@ -1359,6 +1359,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
switches::kEnableShowModalDialog, switches::kEnableShowModalDialog,
switches::kEnableStreamlinedHostedApps, switches::kEnableStreamlinedHostedApps,
switches::kEnableWebBasedSignin, switches::kEnableWebBasedSignin,
switches::kJavaScriptHarmony,
switches::kMessageLoopHistogrammer, switches::kMessageLoopHistogrammer,
switches::kOutOfProcessPdf, switches::kOutOfProcessPdf,
switches::kPlaybackMode, switches::kPlaybackMode,
......
...@@ -759,6 +759,9 @@ const char kInstantProcess[] = "instant-process"; ...@@ -759,6 +759,9 @@ const char kInstantProcess[] = "instant-process";
// enabled. // enabled.
const char kInvalidationUseGCMChannel[] = "invalidation-use-gcm-channel"; const char kInvalidationUseGCMChannel[] = "invalidation-use-gcm-channel";
// Enables experimental Harmony (ECMAScript 6) features.
const char kJavaScriptHarmony[] = "javascript-harmony";
// Specifies the testcase used by the IPC fuzzer. // Specifies the testcase used by the IPC fuzzer.
const char kIpcFuzzerTestcase[] = "ipc-fuzzer-testcase"; const char kIpcFuzzerTestcase[] = "ipc-fuzzer-testcase";
......
...@@ -215,6 +215,7 @@ extern const char kInstallFromWebstore[]; ...@@ -215,6 +215,7 @@ extern const char kInstallFromWebstore[];
extern const char kInstantProcess[]; extern const char kInstantProcess[];
extern const char kInvalidationUseGCMChannel[]; extern const char kInvalidationUseGCMChannel[];
extern const char kIpcFuzzerTestcase[]; extern const char kIpcFuzzerTestcase[];
extern const char kJavaScriptHarmony[];
extern const char kKeepAliveForTest[]; extern const char kKeepAliveForTest[];
extern const char kKioskMode[]; extern const char kKioskMode[];
extern const char kKioskModePrinting[]; extern const char kKioskModePrinting[];
......
...@@ -264,6 +264,11 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver( ...@@ -264,6 +264,11 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver(
if (command_line.HasSwitch(switches::kEnableShowModalDialog)) if (command_line.HasSwitch(switches::kEnableShowModalDialog))
WebRuntimeFeatures::enableShowModalDialog(true); WebRuntimeFeatures::enableShowModalDialog(true);
if (command_line.HasSwitch(switches::kJavaScriptHarmony)) {
std::string flag("--harmony");
v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
}
RenderThread* thread = RenderThread::Get(); RenderThread* thread = RenderThread::Get();
resource_delegate_.reset(new RendererResourceDelegate()); resource_delegate_.reset(new RendererResourceDelegate());
thread->SetResourceDispatcherDelegate(resource_delegate_.get()); thread->SetResourceDispatcherDelegate(resource_delegate_.get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment