Commit 72a8caf6 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Workaround AR StrictMode violation

Works around a StrictMode violation coming from ArCore by allowing disk
writes when checking for ArCore APK availability.

Bug: 1038757
Change-Id: I0fbc469d243d89e14068b5d9ab3fca19999f122b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986246Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Reviewed-by: default avatarPiotr Bialecki <bialpio@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728069}
parent 3622289d
......@@ -38,7 +38,10 @@ class ArCoreShimImpl implements ArCoreShim {
public @Availability int checkAvailability(Context applicationContext) {
// ARCore's checkAvailability reads shared preferences via ArCoreContentProvider, need to
// turn off strict mode to allow that.
try (StrictModeContext ignored = StrictModeContext.allowDiskReads()) {
// TODO(https://crbug.com/1038757): Remove the disk write context when the disk write is
// fixed on ArCore's end.
try (StrictModeContext ignored = StrictModeContext.allowDiskReads();
StrictModeContext ignored2 = StrictModeContext.allowDiskWrites()) {
ArCoreApk.Availability availability =
ArCoreApk.getInstance().checkAvailability(applicationContext);
return mapArCoreApkAvailability(availability);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment