Commit 72b3140d authored by Sajjad Mirza's avatar Sajjad Mirza Committed by Commit Bot

[code coverage] Force instrumentation for clang_profiling.cc on Mac.

Some flakiness has been observed on mac-rel after coverage was enabled
for that builder. The problems correlate with builds that have no
changed source files in Chrome, so we think that forcing coverage for
clang_profiling.cc should solve the problem.

Also remove an outdated comment.

Bug: 1141727
Change-Id: I7ebaeda2ae3a724965e7afa65f20164340c544d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559320
Auto-Submit: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831035}
parent 7818a4ff
......@@ -130,6 +130,13 @@ _COVERAGE_FORCE_LIST_MAP = {
# be linked in. Therefore we force coverage for this file to ensure that
# any target that includes it will also get the profiling runtime.
'win': [r'..\..\base\test\clang_profiling.cc'],
# TODO(crbug.com/1141727) We're seeing runtime LLVM errors in mac-rel when
# no files are changed, so we suspect that this is similar to the other
# problem with clang_profiling.cc on Windows. The TODO here is to force
# coverage for this specific file on ALL platforms, if it turns out to fix
# this issue on Mac as well. It's the only file that directly calls
# `__llvm_profile_dump` so it warrants some special treatment.
'mac': ['../../base/test/clang_profiling.cc'],
}
......@@ -157,7 +164,6 @@ def _remove_flags_from_command(command):
def main():
# TODO(crbug.com/898695): Make this wrapper work on Windows platform.
arg_parser = argparse.ArgumentParser()
arg_parser.usage = __doc__
arg_parser.add_argument(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment