Commit 72df1c59 authored by Natalie Chouinard's avatar Natalie Chouinard Committed by Commit Bot

Remove unused parameter from PrefServiceBridgeJni

The PrefServiceBridge Java caller object is not used on the native side
remove it from all calls.

Bug: 1016957
Change-Id: I3987dd419723fd9a11f00c93fa45a8e738574a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894268Reviewed-by: default avatarPatrick Noland <pnoland@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711817}
parent 80098b78
...@@ -9,7 +9,6 @@ import androidx.annotation.Nullable; ...@@ -9,7 +9,6 @@ import androidx.annotation.Nullable;
import org.chromium.chrome.browser.ContentSettingsType; import org.chromium.chrome.browser.ContentSettingsType;
import org.chromium.chrome.browser.preferences.PrefServiceBridge; import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.PrefServiceBridgeJni;
import java.io.Serializable; import java.io.Serializable;
import java.lang.annotation.Retention; import java.lang.annotation.Retention;
...@@ -81,8 +80,8 @@ public class ContentSettingException implements Serializable { ...@@ -81,8 +80,8 @@ public class ContentSettingException implements Serializable {
* Sets the content setting value for this exception. * Sets the content setting value for this exception.
*/ */
public void setContentSetting(@ContentSettingValues @Nullable Integer value) { public void setContentSetting(@ContentSettingValues @Nullable Integer value) {
PrefServiceBridgeJni.get().setContentSettingForPattern( PrefServiceBridge.getInstance().setContentSettingForPattern(
PrefServiceBridge.getInstance(), mContentSettingType, mPattern, value); mContentSettingType, mPattern, value);
} }
public static @ContentSettingsType int getContentSettingsType(@Type int type) { public static @ContentSettingsType int getContentSettingsType(@Type int type) {
......
...@@ -50,7 +50,6 @@ import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate; ...@@ -50,7 +50,6 @@ import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;
import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils; import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;
import org.chromium.chrome.browser.preferences.Pref; import org.chromium.chrome.browser.preferences.Pref;
import org.chromium.chrome.browser.preferences.PrefServiceBridge; import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.PrefServiceBridgeJni;
import org.chromium.chrome.browser.preferences.PreferenceUtils; import org.chromium.chrome.browser.preferences.PreferenceUtils;
import org.chromium.chrome.browser.preferences.SearchUtils; import org.chromium.chrome.browser.preferences.SearchUtils;
import org.chromium.chrome.browser.preferences.website.Website.StoredDataClearedCallback; import org.chromium.chrome.browser.preferences.website.Website.StoredDataClearedCallback;
...@@ -586,7 +585,7 @@ public class SingleCategoryPreferences extends PreferenceFragmentCompat ...@@ -586,7 +585,7 @@ public class SingleCategoryPreferences extends PreferenceFragmentCompat
? ContentSettingValues.BLOCK ? ContentSettingValues.BLOCK
: ContentSettingValues.ALLOW; : ContentSettingValues.ALLOW;
PrefServiceBridgeJni.get().setContentSettingForPattern(PrefServiceBridge.getInstance(), PrefServiceBridge.getInstance().setContentSettingForPattern(
mCategory.getContentSettingsType(), hostname, setting); mCategory.getContentSettingsType(), hostname, setting);
Toast.makeText(getActivity(), Toast.makeText(getActivity(),
String.format(getActivity().getString( String.format(getActivity().getString(
......
...@@ -44,7 +44,7 @@ public class PrefServiceBridgeTest { ...@@ -44,7 +44,7 @@ public class PrefServiceBridgeTest {
boolean expected = false; boolean expected = false;
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
doReturn(expected).when(mNativeMock).getBoolean(prefServiceBridge, PREF); doReturn(expected).when(mNativeMock).getBoolean(PREF);
assertEquals(expected, prefServiceBridge.getBoolean(PREF)); assertEquals(expected, prefServiceBridge.getBoolean(PREF));
} }
...@@ -56,7 +56,7 @@ public class PrefServiceBridgeTest { ...@@ -56,7 +56,7 @@ public class PrefServiceBridgeTest {
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
prefServiceBridge.setBoolean(PREF, value); prefServiceBridge.setBoolean(PREF, value);
verify(mNativeMock).setBoolean(eq(prefServiceBridge), eq(PREF), eq(value)); verify(mNativeMock).setBoolean(eq(PREF), eq(value));
} }
@Test @Test
...@@ -64,7 +64,7 @@ public class PrefServiceBridgeTest { ...@@ -64,7 +64,7 @@ public class PrefServiceBridgeTest {
int expected = 26; int expected = 26;
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
doReturn(expected).when(mNativeMock).getInteger(prefServiceBridge, PREF); doReturn(expected).when(mNativeMock).getInteger(PREF);
assertEquals(expected, prefServiceBridge.getInteger(PREF)); assertEquals(expected, prefServiceBridge.getInteger(PREF));
} }
...@@ -76,7 +76,7 @@ public class PrefServiceBridgeTest { ...@@ -76,7 +76,7 @@ public class PrefServiceBridgeTest {
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
prefServiceBridge.setInteger(PREF, value); prefServiceBridge.setInteger(PREF, value);
verify(mNativeMock).setInteger(eq(prefServiceBridge), eq(PREF), eq(value)); verify(mNativeMock).setInteger(eq(PREF), eq(value));
} }
@Test @Test
...@@ -84,7 +84,7 @@ public class PrefServiceBridgeTest { ...@@ -84,7 +84,7 @@ public class PrefServiceBridgeTest {
String expected = "foo"; String expected = "foo";
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
doReturn(expected).when(mNativeMock).getString(prefServiceBridge, PREF); doReturn(expected).when(mNativeMock).getString(PREF);
assertEquals(expected, prefServiceBridge.getString(PREF)); assertEquals(expected, prefServiceBridge.getString(PREF));
} }
...@@ -96,7 +96,7 @@ public class PrefServiceBridgeTest { ...@@ -96,7 +96,7 @@ public class PrefServiceBridgeTest {
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
prefServiceBridge.setString(PREF, value); prefServiceBridge.setString(PREF, value);
verify(mNativeMock).setString(eq(prefServiceBridge), eq(PREF), eq(value)); verify(mNativeMock).setString(eq(PREF), eq(value));
} }
@Test @Test
...@@ -104,7 +104,7 @@ public class PrefServiceBridgeTest { ...@@ -104,7 +104,7 @@ public class PrefServiceBridgeTest {
boolean expected = true; boolean expected = true;
PrefServiceBridge prefServiceBridge = new PrefServiceBridge(); PrefServiceBridge prefServiceBridge = new PrefServiceBridge();
doReturn(expected).when(mNativeMock).isManagedPreference(prefServiceBridge, PREF); doReturn(expected).when(mNativeMock).isManagedPreference(PREF);
assertEquals(expected, prefServiceBridge.isManagedPreference(PREF)); assertEquals(expected, prefServiceBridge.isManagedPreference(PREF));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment