v8bindings: Patchwork the crash at LocalWindowProxy::Initialize
We've been observing crashes at LocalWindowProxy::Initialize void LocalWindowProxy::Initialize() { CHECK(!GetFrame()->IsProvisional()); ... } through calls to ToScriptState. This patch patchworks to stop the crash by checking frame->IsProvisional() beforehand. This patch makes ToScriptState return nullptr when the frame is provisional, and it'd potentionally cause crashes on the call sites. (ToScriptState is designed to return nullptr in some cases, so the call sites must have been checking the return value.) Anyway, Blink has been crashing in the case that this patch is bailing out, thus the situation won't become worse. Bug: 1037985, 578349, 1046282 Change-Id: I9497aa740d7b1d14e400c5e416d4a988ff8f488e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024189 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735825}
Showing
Please register or sign in to comment