Turn on only new parser by default.

This CL contains only text fixes:
1.Filling correct FormData
2.Tests that are not applied for the new parser left to be run with the
old parser.
3.ProvisionallySavePassword -> OnPasswordSubmitted
4.Some minor implementation dependent changes in number of calls.

Bug: 831123
Change-Id: I2fe77c002fd7756ca583dc8f753dc89a42650345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602637Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663038}

components/autofill/core/common/save_password_progress_logger.cc

@@ -272,6 +272,8 @@ std::string SavePasswordProgressLogger::GetStringFromID(
       return "|frame| is not the main frame";
     case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVED_FORM_FOR_FRAME:
       return "provisionally_saved_forms_[form_frame]";
+    case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVE_FORM_METHOD:
+      return "PasswordManager::ProvisionallySaveForm";
     case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVE_PASSWORD_METHOD:
       return "PasswordManager::ProvisionallySavePassword";
     case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVE_PASSWORD_FORM:

components/autofill/core/common/save_password_progress_logger.h

@@ -77,6 +77,7 @@ class SavePasswordProgressLogger {
     STRING_DID_START_PROVISIONAL_LOAD_METHOD,
     STRING_FRAME_NOT_MAIN_FRAME,
     STRING_PROVISIONALLY_SAVED_FORM_FOR_FRAME,
+    STRING_PROVISIONALLY_SAVE_FORM_METHOD,
     STRING_PROVISIONALLY_SAVE_PASSWORD_METHOD,
     STRING_PROVISIONALLY_SAVE_PASSWORD_FORM,
     STRING_IS_SAVING_ENABLED,

components/password_manager/core/browser/password_manager.cc

@@ -908,6 +908,7 @@ NewPasswordFormManager* PasswordManager::ProvisionallySaveForm(
   if (password_manager_util::IsLoggingActive(client_)) {
     logger.reset(
         new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
+    logger->LogMessage(Logger::STRING_PROVISIONALLY_SAVE_FORM_METHOD);
   }
   if (!client_->IsSavingAndFillingEnabled(submitted_form.url)) {
     RecordProvisionalSaveFailure(

components/password_manager/core/common/password_manager_features.cc

@@ -52,12 +52,12 @@ const base::Feature kNewPasswordFormParsing = {
 // Enables new password form parsing mechanism for saving passwords, details in
 // https://goo.gl/QodPH1
 const base::Feature kNewPasswordFormParsingForSaving = {
-    "new-password-form-parsing-for-saving", base::FEATURE_DISABLED_BY_DEFAULT};
+    "new-password-form-parsing-for-saving", base::FEATURE_ENABLED_BY_DEFAULT};
 
 // Enables new password form parsing mechanism for saving passwords and disables
 // the old parser, details in https://goo.gl/QodPH1
 const base::Feature kOnlyNewParser = {"only-new-password-form-parsing",
-                                      base::FEATURE_DISABLED_BY_DEFAULT};
+                                      base::FEATURE_ENABLED_BY_DEFAULT};
 
 // Controls the ability to import passwords from Chrome's settings page.
 const base::Feature kPasswordImport = {"PasswordImport",

ios/chrome/browser/passwords/password_controller_unittest.mm

@@ -1260,7 +1260,7 @@ TEST_F(PasswordControllerTest, TouchendAsSubmissionIndicator) {
     // code better to allow proper unit-testing.
     EXPECT_CALL(log_manager, IsLoggingActive()).WillRepeatedly(Return(true));
     const char kExpectedMessage[] =
-        "Message: \"PasswordManager::ProvisionallySavePassword\"\n";
+        "Message: \"PasswordManager::ProvisionallySaveForm\"\n";
     EXPECT_CALL(log_manager, LogSavePasswordProgress(kExpectedMessage));
     EXPECT_CALL(log_manager,
                 LogSavePasswordProgress(testing::Ne(kExpectedMessage)))