Commit 730add3a authored by Gang Wu's avatar Gang Wu Committed by Commit Bot

add user action for remove clipboard suggestions

Bug: 1019252
Change-Id: I92e73ae5f587fc50a05676f7c3eb5502d0caaf64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887891Reviewed-by: default avatarJean-François Geyelin <jif@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711538}
parent 2b74c450
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
#include "base/metrics/field_trial_params.h" #include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "base/optional.h" #include "base/optional.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
...@@ -93,6 +94,9 @@ void RecordCreatingClipboardSuggestionMetrics( ...@@ -93,6 +94,9 @@ void RecordCreatingClipboardSuggestionMetrics(
void RecordDeletingClipboardSuggestionMetrics( void RecordDeletingClipboardSuggestionMetrics(
AutocompleteMatchType::Type match_type, AutocompleteMatchType::Type match_type,
const base::TimeDelta clipboard_contents_age) { const base::TimeDelta clipboard_contents_age) {
base::RecordAction(
base::UserMetricsAction("Omnibox.ClipboardSuggestionRemoved"));
UMA_HISTOGRAM_LONG_TIMES_100("Omnibox.ClipboardSuggestionRemovedAge", UMA_HISTOGRAM_LONG_TIMES_100("Omnibox.ClipboardSuggestionRemovedAge",
clipboard_contents_age); clipboard_contents_age);
if (match_type == AutocompleteMatchType::CLIPBOARD_URL) { if (match_type == AutocompleteMatchType::CLIPBOARD_URL) {
......
...@@ -14785,6 +14785,15 @@ should be able to be added at any place in this file. ...@@ -14785,6 +14785,15 @@ should be able to be added at any place in this file.
</description> </description>
</action> </action>
<action name="Omnibox.ClipboardSuggestionRemoved">
<owner>gangwu@chromium.org</owner>
<owner>lzbylut@google.com</owner>
<description>
User long pressed a clipboard suggestion from the omnibox suggestion list to
remove it from the omnibox suggestion and the system clipboard on Android.
</description>
</action>
<action name="Omnibox.EditUrlSuggestion.Copy"> <action name="Omnibox.EditUrlSuggestion.Copy">
<owner>mdjones@chromium.org</owner> <owner>mdjones@chromium.org</owner>
<owner>lzbylut@google.com</owner> <owner>lzbylut@google.com</owner>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment