Skip to content

GitLab

T
tangled
Commit 7317ac96 authored by kuan@chromium.org's avatar kuan@chromium.org
Browse files
Options

add test for visibility detection 

getComputedStyle() in GWT only works for inline styles, not internal/external
stylesheets.  so add a test in browser instead.

BUG=367243
TBR=blundell

Review URL: https://codereview.chromium.org/278873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271666 0039d316-1c4b-4281-b951-d872f2087c98
parent 4db65f95
Hide whitespace changes
Inline Side-by-side
Showing with 57 additions and 0 deletions
components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
View file @ 7317ac96
...@@ -118,4 +118,27 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeImages) { ...@@ -118,4 +118,27 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeImages) {
HasSubstr("src=\"http://www.google.com/absoluteimage.png\"")); HasSubstr("src=\"http://www.google.com/absoluteimage.png\""));
} }
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, VisibilityDetection) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext());
distiller_page_ = &distiller_page;
// visble_style.html and invisible_style.html only differ by the visibility
// internal stylesheet.
{
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), "/visible_style.html");
run_loop.Run();
EXPECT_THAT(page_info_.get()->html, HasSubstr("Lorem ipsum"));
}
{
base::RunLoop run_loop;
DistillPage(run_loop.QuitClosure(), "/invisible_style.html");
run_loop.Run();
EXPECT_THAT(page_info_.get()->html, Not(HasSubstr("Lorem ipsum")));
}
}
} // namespace dom_distiller } // namespace dom_distiller
components/test/data/dom_distiller/invisible_style.html 0 → 100644
View file @ 7317ac96
<html>
<head>
<title>Visibility Detection Test</title>
<style>
#foo { display:none; }
</style>
</head>
<body>
<div id="foo">
<p>Lorem ipsum dolor sit amet, at alia aliquip vel. Quas inani labore an vel. Sed an nemore minimum accusata. Sint inermis tacimates est ex, ad movet iracundia mei, delicata iracundia laboramus ei eos. Illud principes complectitur te nec, ius alienum insolens ea, cu quo oratio omnesque.
<p>Lorem ipsum dolor sit amet, at alia aliquip vel. Quas inani labore an vel. Sed an nemore minimum accusata. Sint inermis tacimates est ex, ad movet iracundia mei, delicata iracundia laboramus ei eos. Illud principes complectitur te nec, ius alienum insolens ea, cu quo oratio omnesque.
</div>
</body>
</html>
components/test/data/dom_distiller/visible_style.html 0 → 100644
View file @ 7317ac96
<html>
<head>
<title>Visibility Detection Test</title>
<style>
#foo { display:table; }
</style>
</head>
<body>
<div id="foo">
<p>Lorem ipsum dolor sit amet, at alia aliquip vel. Quas inani labore an vel. Sed an nemore minimum accusata. Sint inermis tacimates est ex, ad movet iracundia mei, delicata iracundia laboramus ei eos. Illud principes complectitur te nec, ius alienum insolens ea, cu quo oratio omnesque.
<p>Lorem ipsum dolor sit amet, at alia aliquip vel. Quas inani labore an vel. Sed an nemore minimum accusata. Sint inermis tacimates est ex, ad movet iracundia mei, delicata iracundia laboramus ei eos. Illud principes complectitur te nec, ius alienum insolens ea, cu quo oratio omnesque.
</div>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment