Commit 7368a3ec authored by avi's avatar avi Committed by Commit bot

Remove base::ScopedPtrHashMap from extensions/.

BUG=579229

Review-Url: https://codereview.chromium.org/2605953002
Cr-Commit-Position: refs/heads/master@{#440921}
parent 2239d36e
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include "base/lazy_instance.h" #include "base/lazy_instance.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "content/public/child/worker_thread.h" #include "content/public/child/worker_thread.h"
#include "content/public/renderer/render_thread.h" #include "content/public/renderer/render_thread.h"
#include "extensions/common/extension_messages.h" #include "extensions/common/extension_messages.h"
...@@ -160,10 +161,9 @@ void WakeEventPage::MakeRequest(const std::string& extension_id, ...@@ -160,10 +161,9 @@ void WakeEventPage::MakeRequest(const std::string& extension_id,
static base::AtomicSequenceNumber sequence_number; static base::AtomicSequenceNumber sequence_number;
int request_id = sequence_number.GetNext(); int request_id = sequence_number.GetNext();
{ {
std::unique_ptr<RequestData> request_data(
new RequestData(content::WorkerThread::GetCurrentId(), on_response));
base::AutoLock lock(requests_lock_); base::AutoLock lock(requests_lock_);
requests_.set(request_id, std::move(request_data)); requests_[request_id] = base::MakeUnique<RequestData>(
content::WorkerThread::GetCurrentId(), on_response);
} }
message_filter_->Send( message_filter_->Send(
new ExtensionHostMsg_WakeEventPage(request_id, extension_id)); new ExtensionHostMsg_WakeEventPage(request_id, extension_id));
...@@ -183,9 +183,11 @@ void WakeEventPage::OnWakeEventPageResponse(int request_id, bool success) { ...@@ -183,9 +183,11 @@ void WakeEventPage::OnWakeEventPageResponse(int request_id, bool success) {
std::unique_ptr<RequestData> request_data; std::unique_ptr<RequestData> request_data;
{ {
base::AutoLock lock(requests_lock_); base::AutoLock lock(requests_lock_);
request_data = requests_.take(request_id); auto it = requests_.find(request_id);
CHECK(it != requests_.end()) << "No request with ID " << request_id;
request_data = std::move(it->second);
requests_.erase(it);
} }
CHECK(request_data) << "No request with ID " << request_id;
if (request_data->thread_id == 0) { if (request_data->thread_id == 0) {
// Thread ID of 0 means it wasn't called on a worker thread, so safe to // Thread ID of 0 means it wasn't called on a worker thread, so safe to
// call immediately. // call immediately.
......
...@@ -7,9 +7,9 @@ ...@@ -7,9 +7,9 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include <unordered_map>
#include "base/callback.h" #include "base/callback.h"
#include "base/containers/scoped_ptr_hash_map.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/memory/ref_counted.h" #include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
...@@ -103,7 +103,7 @@ class WakeEventPage : public content::RenderThreadObserver { ...@@ -103,7 +103,7 @@ class WakeEventPage : public content::RenderThreadObserver {
// All in-flight requests, keyed by request ID. Used on multiple threads, so // All in-flight requests, keyed by request ID. Used on multiple threads, so
// must be guarded by |requests_lock_|. // must be guarded by |requests_lock_|.
base::ScopedPtrHashMap<int, std::unique_ptr<RequestData>> requests_; std::unordered_map<int, std::unique_ptr<RequestData>> requests_;
// Lock for |requests_|. // Lock for |requests_|.
base::Lock requests_lock_; base::Lock requests_lock_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment