Commit 73733459 authored by Lindsay Pasricha's avatar Lindsay Pasricha Committed by Commit Bot

Disable testActivityServiceControllerCantPrintUnprintablePages and...

Disable testActivityServiceControllerCantPrintUnprintablePages and testOpenActivityServiceControllerAndCopy

These were previously just disabled using the EARL_GREY_TEST_DISABLED
macro but that should only be used when it's a partial disable, not
for when a test is disabled across the board.

Bug: 747622,864597
Change-Id: I5ef336aeefeb50e8984d5e149dc2241d6ae63f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697288
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683431}
parent 5fd57903
......@@ -71,14 +71,11 @@ id<GREYMatcher> ShareMenuCollectionView() {
@implementation ActivityServiceControllerTestCase
- (void)testActivityServiceControllerCantPrintUnprintablePages {
// TODO(crbug.com/747622): re-enable this test on once earl grey can interact
// with the share menu.
EARL_GREY_TEST_DISABLED(@"Disabled until EG can use share menu.");
// TODO(crbug.com/864597): Reenable this test.
EARL_GREY_TEST_DISABLED(@"Test should be rewritten to use Offline Version.");
// TODO(crbug.com/747622): re-enable this test on once earl grey can interact
// with the share menu.
// TODO(crbug.com/864597): Reenable this test. This test should be rewritten
// to use Offline Version.
- (void)DISABLED_testActivityServiceControllerCantPrintUnprintablePages {
std::unique_ptr<web::DataResponseProvider> provider(
new ErrorPageResponseProvider());
web::test::SetUpHttpServer(std::move(provider));
......@@ -116,11 +113,9 @@ id<GREYMatcher> ShareMenuCollectionView() {
UIAccessibilityTraitNotEnabled)];
}
- (void)testOpenActivityServiceControllerAndCopy {
// TODO(crbug.com/747622): re-enable this test once earl grey can interact
// with the share menu.
EARL_GREY_TEST_DISABLED(@"Disabled until EG can use share menu.");
// TODO(crbug.com/747622): re-enable this test once earl grey can interact
// with the share menu.
- (void)DISABLED_testOpenActivityServiceControllerAndCopy {
// Set up mock http server.
std::map<GURL, std::string> responses;
GURL url = web::test::HttpServer::MakeUrl("http://potato");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment