Commit 7389fb70 authored by George Burgess IV's avatar George Burgess IV Committed by Commit Bot

fix instances of bugprone-argument-comment

This new clang-tidy check complains when param names /*in_comments=*/
don't match up with the actual parameter name they're being passed to.
Sometimes this is benign, other times, actual bugs are found.

Bug: 1136209
Change-Id: I9ba052ae97bfc618224f84271de28f8f4c81443c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459269Reviewed-by: default avatarJosh Karlin <jkarlin@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815665}
parent 24d5f15b
...@@ -3719,9 +3719,9 @@ TEST_F(DiskCacheEntryTest, SimpleCacheDoomCreateOptimistic) { ...@@ -3719,9 +3719,9 @@ TEST_F(DiskCacheEntryTest, SimpleCacheDoomCreateOptimistic) {
base::MakeRefCounted<net::IOBuffer>(kSize); base::MakeRefCounted<net::IOBuffer>(kSize);
CacheTestFillBuffer(buf_1->data(), kSize, false); CacheTestFillBuffer(buf_1->data(), kSize, false);
EXPECT_EQ(kSize, WriteData(entry2, /* stream_index = */ 1, /* offset = */ 0, EXPECT_EQ(kSize, WriteData(entry2, /* index = */ 1, /* offset = */ 0,
buf_1.get(), kSize, /* truncate = */ false)); buf_1.get(), kSize, /* truncate = */ false));
EXPECT_EQ(kSize, ReadData(entry2, /* stream_index = */ 1, /* offset = */ 0, EXPECT_EQ(kSize, ReadData(entry2, /* index = */ 1, /* offset = */ 0,
buf_2.get(), kSize)); buf_2.get(), kSize));
doom_callback.WaitForResult(); doom_callback.WaitForResult();
...@@ -5288,24 +5288,24 @@ void DiskCacheEntryTest::TruncateBackwards() { ...@@ -5288,24 +5288,24 @@ void DiskCacheEntryTest::TruncateBackwards() {
scoped_refptr<net::IOBuffer> read_buf = scoped_refptr<net::IOBuffer> read_buf =
base::MakeRefCounted<net::IOBuffer>(kBigSize); base::MakeRefCounted<net::IOBuffer>(kBigSize);
ASSERT_EQ(kSmallSize, WriteData(entry, /* stream_index = */ 0, ASSERT_EQ(kSmallSize, WriteData(entry, /* index = */ 0,
/* offset = */ kBigSize, buffer.get(), /* offset = */ kBigSize, buffer.get(),
/* size = */ kSmallSize, /* size = */ kSmallSize,
/* truncate = */ false)); /* truncate = */ false));
memset(read_buf->data(), 0, kBigSize); memset(read_buf->data(), 0, kBigSize);
ASSERT_EQ(kSmallSize, ReadData(entry, /* stream_index = */ 0, ASSERT_EQ(kSmallSize, ReadData(entry, /* index = */ 0,
/* offset = */ kBigSize, read_buf.get(), /* offset = */ kBigSize, read_buf.get(),
/* size = */ kSmallSize)); /* size = */ kSmallSize));
EXPECT_EQ(0, memcmp(read_buf->data(), buffer->data(), kSmallSize)); EXPECT_EQ(0, memcmp(read_buf->data(), buffer->data(), kSmallSize));
// A partly overlapping truncate before the previous write. // A partly overlapping truncate before the previous write.
ASSERT_EQ(kBigSize, ASSERT_EQ(kBigSize,
WriteData(entry, /* stream_index = */ 0, WriteData(entry, /* index = */ 0,
/* offset = */ 3, buffer.get(), /* size = */ kBigSize, /* offset = */ 3, buffer.get(), /* size = */ kBigSize,
/* truncate = */ true)); /* truncate = */ true));
memset(read_buf->data(), 0, kBigSize); memset(read_buf->data(), 0, kBigSize);
ASSERT_EQ(kBigSize, ASSERT_EQ(kBigSize,
ReadData(entry, /* stream_index = */ 0, ReadData(entry, /* index = */ 0,
/* offset = */ 3, read_buf.get(), /* size = */ kBigSize)); /* offset = */ 3, read_buf.get(), /* size = */ kBigSize));
EXPECT_EQ(0, memcmp(read_buf->data(), buffer->data(), kBigSize)); EXPECT_EQ(0, memcmp(read_buf->data(), buffer->data(), kBigSize));
EXPECT_EQ(kBigSize + 3, entry->GetDataSize(0)); EXPECT_EQ(kBigSize + 3, entry->GetDataSize(0));
...@@ -5345,15 +5345,15 @@ void DiskCacheEntryTest::ZeroWriteBackwards() { ...@@ -5345,15 +5345,15 @@ void DiskCacheEntryTest::ZeroWriteBackwards() {
// Offset here needs to be > blockfile's kMaxBlockSize to hit // Offset here needs to be > blockfile's kMaxBlockSize to hit
// https://crbug.com/946538, as writes close to beginning are handled // https://crbug.com/946538, as writes close to beginning are handled
// specially. // specially.
EXPECT_EQ(0, WriteData(entry, /* stream_index = */ 0, EXPECT_EQ(0, WriteData(entry, /* index = */ 0,
/* offset = */ 17000, buffer.get(), /* offset = */ 17000, buffer.get(),
/* size = */ 0, /* truncate = */ true)); /* size = */ 0, /* truncate = */ true));
EXPECT_EQ(0, WriteData(entry, /* stream_index = */ 0, EXPECT_EQ(0, WriteData(entry, /* index = */ 0,
/* offset = */ 0, buffer.get(), /* offset = */ 0, buffer.get(),
/* size = */ 0, /* truncate = */ false)); /* size = */ 0, /* truncate = */ false));
EXPECT_EQ(kSize, ReadData(entry, /* stream_index = */ 0, EXPECT_EQ(kSize, ReadData(entry, /* index = */ 0,
/* offset = */ 0, buffer.get(), /* offset = */ 0, buffer.get(),
/* size = */ kSize)); /* size = */ kSize));
for (int i = 0; i < kSize; ++i) { for (int i = 0; i < kSize; ++i) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment