Commit 73934328 authored by Hayato Ito's avatar Hayato Ito Committed by Commit Bot

sheriff: Disable flaky OmniboxViewTest.DesiredTLD

The test is flaky on other than ASAN and TSAN.

TBR=tommycli@chromium.org,robliao@chromium.org

Bug: 1030551
Change-Id: I8cf22b93f1c7f3bc4c7c21b3e3d0e484fe6d5458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986544Reviewed-by: default avatarHayato Ito <hayato@chromium.org>
Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728771}
parent d71738b5
...@@ -531,14 +531,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BackspaceInKeywordMode) { ...@@ -531,14 +531,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, BackspaceInKeywordMode) {
UTF16ToUTF8(omnibox_view->GetText())); UTF16ToUTF8(omnibox_view->GetText()));
} }
// TODO(https://crbug.com/1030551): This test flakily times out on ASAN and // TODO(https://crbug.com/1030551): This test flakily times out.
// TSAN. IN_PROC_BROWSER_TEST_F(OmniboxViewTest, DISABLED_DesiredTLD) {
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_DesiredTLD DISABLED_DesiredTLD
#else
#define MAYBE_DesiredTLD DesiredTLD
#endif
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, MAYBE_DesiredTLD) {
OmniboxView* omnibox_view = NULL; OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view)); ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
OmniboxPopupModel* popup_model = omnibox_view->model()->popup_model(); OmniboxPopupModel* popup_model = omnibox_view->model()->popup_model();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment