Commit 73a8ca2f authored by creis@chromium.org's avatar creis@chromium.org

Remove unnecessary ContentBrowserClient in test.

DevToolsManagerTest was forcing a process swap using
ShouldSwapProcessesForNavigation, but this was unnecessary since the
navigation was cross-site anyway.  Removing the extra code so that it doesn't
force an unnecessary swap on the first navigation.

BUG=123007
TEST=DevToolsManagerTest.ReattachOnCancelPendingNavigation

Review URL: https://codereview.chromium.org/53293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232916 0039d316-1c4b-4281-b951-d872f2087c98
parent e2f70c22
......@@ -87,41 +87,14 @@ class TestWebContentsDelegate : public WebContentsDelegate {
bool renderer_unresponsive_received_;
};
class DevToolsManagerTestBrowserClient : public TestContentBrowserClient {
public:
DevToolsManagerTestBrowserClient() {
}
virtual bool ShouldSwapProcessesForNavigation(
SiteInstance* site_instance,
const GURL& current_url,
const GURL& new_url) OVERRIDE {
return true;
}
private:
DISALLOW_COPY_AND_ASSIGN(DevToolsManagerTestBrowserClient);
};
} // namespace
class DevToolsManagerTest : public RenderViewHostImplTestHarness {
protected:
virtual void SetUp() OVERRIDE {
original_browser_client_ = SetBrowserClientForTesting(&browser_client_);
RenderViewHostImplTestHarness::SetUp();
TestDevToolsClientHost::ResetCounters();
}
virtual void TearDown() OVERRIDE {
RenderViewHostImplTestHarness::TearDown();
SetBrowserClientForTesting(original_browser_client_);
}
private:
ContentBrowserClient* original_browser_client_;
DevToolsManagerTestBrowserClient browser_client_;
};
TEST_F(DevToolsManagerTest, OpenAndManuallyCloseDevToolsClientHost) {
......@@ -200,7 +173,6 @@ TEST_F(DevToolsManagerTest, NoUnresponsiveDialogInInspectedContents) {
}
TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {
contents()->transition_cross_site = true;
// Navigate to URL. First URL should use first RenderViewHost.
const GURL url("http://www.google.com");
controller().LoadURL(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment