Added a comment to PlatformAppBrowserTest.WindowDotPrintWorks.

The PlatformAppBrowserTest.WindowDotPrintWorks test will only run
automatically for Chrome branded builds because it requires the PDF
plug-in, which isn't provided for Chromium builds. The added comment
explain how to run the test manually for Chromium builds.

TBR=asargent@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/23521007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221907 0039d316-1c4b-4281-b951-d872f2087c98
parent d04658e1
...@@ -1037,12 +1037,18 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WebContentsHasFocus) { ...@@ -1037,12 +1037,18 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WebContentsHasFocus) {
GetRenderWidgetHostView()->HasFocus()); GetRenderWidgetHostView()->HasFocus());
} }
// Currently this test only works if the PDF preview plug-in is available. This // The next test will only run automatically with Chrome branded builds because
// will only happen in Chrome release builds or if the plug-in has been manually // it requires the PDF preview plug-in. To run this test manually for Chromium
// copied from a Chrome release build. In the former case, this test will run // builds (non-Chrome branded) in a development environment:
// automatically. In the later case, it can be run manually by commenting out //
// the next three lines and the corresponding #endif and then running // 1) Remove "MAYBE_" in the first line of the test definition
// browser_tests with a --enable-print-preview flag. // 2) Build Chromium browser_tests
// 3) Make a copy of the PDF plug-in from a recent version of Chrome (Canary
// or recent development build) to your Chromium build. On Linux and Chrome
// OS, this just involves copying /opt/google.chrome/libpdf.so to
// <path-to-your-src>/out/Debug.
// 4) Run browser_tests with the --enable-print-preview flag
#if !defined(GOOGLE_CHROME_BUILD) #if !defined(GOOGLE_CHROME_BUILD)
#define MAYBE_WindowDotPrintWorks DISABLED_WindowDotPrintWorks #define MAYBE_WindowDotPrintWorks DISABLED_WindowDotPrintWorks
#else #else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment