Remove Headers.prototype.getAll()

It's no longer part of the spec
(https://github.com/whatwg/fetch/commit/42464c)

intent-to-deprecate-and-remove
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/x3YXciXQWM0

BUG=645492

Review-Url: https://codereview.chromium.org/2591723003
Cr-Commit-Position: refs/heads/master@{#468022}

android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt

@@ -2537,7 +2537,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/http/tests/fetch/resources/thorough-util.js

@@ -345,15 +345,11 @@ function headersToArray(headers) {
   // iterable.
   ['content-length', 'content-type', 'x-serviceworker-serverheader'].forEach(
     function(name) {
-      for (var value of headers.getAll(name))
-        ret.push([name, value]);
+      for (var header of headers){
+        ret.push(header);
+      }
     });
 
-  // Original code:
-  // for (var header of headers) {
-  //   ret.push(header);
-  // }
-
   return ret;
 }
 

third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/headers.js

@@ -128,8 +128,8 @@ test(function() {
       assert_equals(headersObject, headers);
     }, thisObject);
 
-    // 'append()', 'getAll()'
-    var allValues = headers.getAll('X-Fetch-Test');
+    // 'append()'
+    var allValues = headers.get('X-Fetch-Test').split(', ');
     assert_equals(allValues.length, 1);
     assert_equals(size(headers), 4);
     headers.append('X-FETCH-TEST', 'response test field - append');
@@ -138,13 +138,13 @@ test(function() {
     assert_equals(headers.get('X-FETCH-Test'),
                   'response test field - updated, response test field - append',
                   'the value of the first header added should be returned.');
-    allValues = headers.getAll('X-FETch-TEST');
+    allValues = headers.get('X-FETch-TEST').split(', ');
     assert_equals(allValues.length, 2);
     assert_equals(allValues[0], 'response test field - updated');
     assert_equals(allValues[1], 'response test field - append');
     headers.set('X-FETch-Test', 'response test field - set');
     assert_equals(size(headers), 5, 'the second header should be deleted');
-    allValues = headers.getAll('X-Fetch-Test');
+    allValues = headers.get('X-Fetch-Test').split(', ');
     assert_equals(allValues.length, 1, 'the second header should be deleted');
     assert_equals(allValues[0], 'response test field - set');
     headers.append('X-Fetch-TEST', 'response test field - append');
@@ -157,16 +157,16 @@ test(function() {
     assert_equals(size(headers), 2, 'headers size should match');
     assert_equals(headers.get('a'), 'b');
     assert_equals(headers.get('c'), 'd, e');
-    assert_equals(headers.getAll('c')[0], 'd');
-    assert_equals(headers.getAll('c')[1], 'e');
+    assert_equals(headers.get('c').split(', ')[0], 'd');
+    assert_equals(headers.get('c').split(', ')[1], 'e');
 
     // new Headers with Headers
     var headers2 = new Headers(headers);
     assert_equals(size(headers2), 2, 'headers size should match');
     assert_equals(headers2.get('a'), 'b');
     assert_equals(headers2.get('c'), 'd, e');
-    assert_equals(headers2.getAll('c')[0], 'd');
-    assert_equals(headers2.getAll('c')[1], 'e');
+    assert_equals(headers2.get('c').split(', ')[0], 'd');
+    assert_equals(headers2.get('c').split(', ')[1], 'e');
     headers.set('a', 'x');
     assert_equals(headers.get('a'), 'x');
     assert_equals(headers2.get('a'), 'b');

third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js

@@ -113,44 +113,44 @@ test(function() {
     assert_equals(request2.mode, 'cors', 'Request.mode should match');
     assert_equals(request2.credentials, 'omit',
                   'Request.credentials should match');
-    assert_equals(request2.headers.getAll('X-Fetch-Foo')[0], 'foo1',
+    assert_equals(request2.headers.get('X-Fetch-Foo').split(', ')[0], 'foo1',
                   'Request.headers should match');
-    assert_equals(request2.headers.getAll('X-Fetch-Foo')[1], 'foo2',
+    assert_equals(request2.headers.get('X-Fetch-Foo').split(', ')[1], 'foo2',
                   'Request.headers should match');
-    assert_equals(request2.headers.getAll('X-Fetch-Bar')[0], 'bar',
+    assert_equals(request2.headers.get('X-Fetch-Bar').split(', ')[0], 'bar',
                   'Request.headers should match');
     var request3 = new Request(URL,
                                {headers: [['X-Fetch-Foo', 'foo1'],
                                           ['X-Fetch-Foo', 'foo2'],
                                           ['X-Fetch-Bar', 'bar']]});
-    assert_equals(request3.headers.getAll('X-Fetch-Foo')[0], 'foo1',
+    assert_equals(request3.headers.get('X-Fetch-Foo').split(', ')[0], 'foo1',
                   'Request.headers should match');
-    assert_equals(request3.headers.getAll('X-Fetch-Foo')[1], 'foo2',
+    assert_equals(request3.headers.get('X-Fetch-Foo').split(', ')[1], 'foo2',
                   'Request.headers should match');
-    assert_equals(request3.headers.getAll('X-Fetch-Bar')[0], 'bar',
+    assert_equals(request3.headers.get('X-Fetch-Bar').split(', ')[0], 'bar',
                   'Request.headers should match');
     var request4 = new Request(URL,
                                {headers: {'X-Fetch-Foo': 'foo1',
                                           'X-Fetch-Foo': 'foo2',
                                           'X-Fetch-Bar': 'bar'}});
-    assert_equals(request4.headers.getAll('X-Fetch-Foo')[0], 'foo2',
+    assert_equals(request4.headers.get('X-Fetch-Foo').split(', ')[0], 'foo2',
                   'Request.headers should match');
-    assert_equals(request4.headers.getAll('X-Fetch-Bar')[0], 'bar',
+    assert_equals(request4.headers.get('X-Fetch-Bar').split(', ')[0], 'bar',
                   'Request.headers should match');
     // https://github.com/whatwg/fetch/issues/479
     var request5 = new Request(request, {headers: undefined});
-    assert_equals(request5.headers.getAll('X-Fetch-Foo')[0], 'foo1',
+    assert_equals(request5.headers.get('X-Fetch-Foo').split(', ')[0], 'foo1',
                   'Request.headers should match');
-    assert_equals(request5.headers.getAll('X-Fetch-Foo')[1], 'foo2',
+    assert_equals(request5.headers.get('X-Fetch-Foo').split(', ')[1], 'foo2',
                   'Request.headers should match');
-    assert_equals(request5.headers.getAll('X-Fetch-Bar')[0], 'bar',
+    assert_equals(request5.headers.get('X-Fetch-Bar').split(', ')[0], 'bar',
                   'Request.headers should match');
     var request6 = new Request(request, {});
-    assert_equals(request6.headers.getAll('X-Fetch-Foo')[0], 'foo1',
+    assert_equals(request6.headers.get('X-Fetch-Foo').split(', ')[0], 'foo1',
                   'Request.headers should match');
-    assert_equals(request6.headers.getAll('X-Fetch-Foo')[1], 'foo2',
+    assert_equals(request6.headers.get('X-Fetch-Foo').split(', ')[1], 'foo2',
                   'Request.headers should match');
-    assert_equals(request6.headers.getAll('X-Fetch-Bar')[0], 'bar',
+    assert_equals(request6.headers.get('X-Fetch-Bar').split(', ')[0], 'bar',
                   'Request.headers should match');
     assert_throws(new TypeError(),
                   () => { new Request(request, {headers: null}) },

third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -450,7 +450,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -237,7 +237,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt

@@ -250,7 +250,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt

@@ -2921,7 +2921,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt

@@ -245,7 +245,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt

@@ -2850,7 +2850,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -449,7 +449,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt

@@ -458,7 +458,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt

@@ -3550,7 +3550,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt

@@ -453,7 +453,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -450,7 +450,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt

@@ -237,7 +237,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt

@@ -250,7 +250,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt

@@ -245,7 +245,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt

@@ -458,7 +458,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt

@@ -3550,7 +3550,6 @@ interface Headers
     method entries
     method forEach
     method get
-    method getAll
     method has
     method keys
     method set

third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt

@@ -453,7 +453,6 @@ Starting worker: resources/global-interface-listing.js
 [Worker]     method entries
 [Worker]     method forEach
 [Worker]     method get
-[Worker]     method getAll
 [Worker]     method has
 [Worker]     method keys
 [Worker]     method set

third_party/WebKit/Source/modules/fetch/Headers.cpp

@@ -167,21 +167,6 @@ String Headers::get(const String& name, ExceptionState& exception_state) {
   return result;
 }
 
-Vector<String> Headers::getAll(const String& name,
-                               ExceptionState& exception_state) {
-  // "The getAll(|name|) method, when invoked, must run these steps:"
-  // "1. If |name| is not a name, throw a TypeError."
-  if (!FetchHeaderList::IsValidHeaderName(name)) {
-    exception_state.ThrowTypeError("Invalid name");
-    return Vector<String>();
-  }
-  // "2. Return the values of all headers in header list whose name is |name|,
-  //     in list order, and the empty sequence otherwise."
-  Vector<String> result;
-  header_list_->GetAll(name, result);
-  return result;
-}
-
 bool Headers::has(const String& name, ExceptionState& exception_state) {
   // "The has(|name|) method, when invoked, must run these steps:"
   // "1. If |name| is not a name, throw a TypeError."

third_party/WebKit/Source/modules/fetch/Headers.h

@@ -46,7 +46,6 @@ class MODULES_EXPORT Headers final : public GarbageCollected<Headers>,
   void append(const String& name, const String& value, ExceptionState&);
   void remove(const String& key, ExceptionState&);
   String get(const String& key, ExceptionState&);
-  Vector<String> getAll(const String& key, ExceptionState&);
   bool has(const String& key, ExceptionState&);
   void set(const String& key, const String& value, ExceptionState&);
 

third_party/WebKit/Source/modules/fetch/Headers.idl

@@ -20,7 +20,6 @@ typedef (sequence<sequence<ByteString>> or record<ByteString, ByteString> or Hea
     [RaisesException] void append(ByteString name, ByteString value);
     [ImplementedAs=remove, RaisesException] void delete(ByteString key);
     [RaisesException] ByteString? get(ByteString key);
-    [RaisesException, Measure] sequence<ByteString> getAll(ByteString name);
     [RaisesException] boolean has(ByteString key);
     [RaisesException] void set(ByteString key, ByteString value);
     iterable<ByteString, ByteString>;