Commit 74046b75 authored by Mike Jackson (EDGE)'s avatar Mike Jackson (EDGE) Committed by Commit Bot

Desktop PWAs: pending_app_manager_impl_unittests only run with BMO flag disabled

Per feedback, submitting a separate change to explicitly disable
BMO flag for this test to unblock BMO in ToT.

A follow up change should create a fork of this test for BMO using
TestWebAppRegistryController.

Bug: 1082854
Change-Id: Ibe4c5c64715f01620d3cc857dc6588746445130c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206219Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#769824}
parent b2cbcffa
......@@ -17,6 +17,7 @@
#include "base/optional.h"
#include "base/run_loop.h"
#include "base/test/bind_test_util.h"
#include "base/test/scoped_feature_list.h"
#include "base/timer/mock_timer.h"
#include "chrome/browser/web_applications/components/app_registrar.h"
#include "chrome/browser/web_applications/components/install_finalizer.h"
......@@ -30,6 +31,7 @@
#include "chrome/browser/web_applications/test/test_web_app_ui_manager.h"
#include "chrome/browser/web_applications/test/test_web_app_url_loader.h"
#include "chrome/browser/web_applications/test/web_app_registration_waiter.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/testing_profile.h"
#include "testing/gtest/include/gtest/gtest.h"
......@@ -301,7 +303,10 @@ class TestPendingAppManagerImpl : public PendingAppManagerImpl {
class PendingAppManagerImplTest : public ChromeRenderViewHostTestHarness {
public:
PendingAppManagerImplTest() = default;
PendingAppManagerImplTest() {
scoped_feature_list_.InitAndDisableFeature(
features::kDesktopPWAsWithoutExtensions);
}
~PendingAppManagerImplTest() override = default;
......@@ -444,6 +449,7 @@ class PendingAppManagerImplTest : public ChromeRenderViewHostTestHarness {
TestInstallFinalizer* install_finalizer() { return install_finalizer_; }
private:
base::test::ScopedFeatureList scoped_feature_list_;
TestAppRegistrar* app_registrar_ = nullptr;
TestPendingAppManagerImpl* pending_app_manager_impl_ = nullptr;
TestInstallFinalizer* install_finalizer_ = nullptr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment