Commit 7438d088 authored by Boris Sazonov's avatar Boris Sazonov Committed by Commit Bot

[Signin][Android] Disable sign-in button on Google Play services error

Disable 'Yes, I'm in' button in the sign-in screen if
AccountManagerFacade couldn't obtain accounts due to Google Play
services error. mHasGmsError is already checked
SigninFragmentBase.areControlsEnabled, so click will be ignored either
way. In this case, making the button actually disabled should reduce
the confusion.

Bug: 997218
Change-Id: Icc84b82290e3df981afe7b6a4871a84e53a31735
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807326
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: default avatarAlex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697249}
parent 65cbfbae
...@@ -587,7 +587,8 @@ public abstract class SigninFragmentBase ...@@ -587,7 +587,8 @@ public abstract class SigninFragmentBase
mAccountNames = getAccountNames(maybeAccountNames); mAccountNames = getAccountNames(maybeAccountNames);
mHasGmsError = mAccountNames == null; mHasGmsError = mAccountNames == null;
if (mAccountNames == null) return; mView.getAcceptButton().setEnabled(!mHasGmsError);
if (mHasGmsError) return;
if (mAccountNames.isEmpty()) { if (mAccountNames.isEmpty()) {
mSelectedAccountName = null; mSelectedAccountName = null;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment