Commit 7443f460 authored by Tibor Goldschwendt's avatar Tibor Goldschwendt Committed by Commit Bot

[webui][ntp] Log WebUINTP_LinkOpenedFromContextMenu

NewTabPage.LinkOpenedFromContextMenu.WebUI is the WebUI equivalent of
NTP_LinkOpenedFromContextMenu and MostVisited_ClickedFromContextMenu on
the local NTP.

+ Update ownership of the three aforementioned user actions.

Bug: 1074060
Change-Id: I59e412ad48894cefc1d7bc3dd599ee45c072d62d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208183
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770331}
parent 9c037b6b
...@@ -990,6 +990,11 @@ void RenderViewContextMenu::RecordUsedItem(int id) { ...@@ -990,6 +990,11 @@ void RenderViewContextMenu::RecordUsedItem(int id) {
} else if (doc_url.GetOrigin() == chrome::kChromeSearchMostVisitedUrl) { } else if (doc_url.GetOrigin() == chrome::kChromeSearchMostVisitedUrl) {
base::RecordAction( base::RecordAction(
base::UserMetricsAction("MostVisited_ClickedFromContextMenu")); base::UserMetricsAction("MostVisited_ClickedFromContextMenu"));
} else if (doc_url.GetOrigin() == GURL(chrome::kChromeUINewTabPageURL) ||
doc_url.GetOrigin() ==
GURL(chrome::kChromeUIUntrustedNewTabPageUrl)) {
base::RecordAction(base::UserMetricsAction(
"NewTabPage.LinkOpenedFromContextMenu.WebUI"));
} }
} }
......
...@@ -14954,9 +14954,10 @@ should be able to be added at any place in this file. ...@@ -14954,9 +14954,10 @@ should be able to be added at any place in this file.
</action> </action>
<action name="MostVisited_ClickedFromContextMenu"> <action name="MostVisited_ClickedFromContextMenu">
<owner>dbeam@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>kristipark@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-analysis-team@google.com</owner> <owner>chrome-analysis-team@google.com</owner>
<owner>chrome-desktop-ntp@google.com</owner>
<description> <description>
An NTP tile was opened from the context menu. Desktop only. An NTP tile was opened from the context menu. Desktop only.
...@@ -15227,6 +15228,23 @@ should be able to be added at any place in this file. ...@@ -15227,6 +15228,23 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description> <description>Please enter the description of this user action.</description>
</action> </action>
<action name="NewTabPage.LinkOpenedFromContextMenu.WebUI">
<owner>tiborg@chromium.org</owner>
<owner>yyushkina@chromium.org</owner>
<owner>chrome-analysis-team@google.com</owner>
<owner>chrome-desktop-ntp@google.com</owner>
<description>
Recorded when a link on the WebUI New Tab Page is opened via the context
menu. This can include: Middle-slot promos, Doodles, the One Google Bar,
shortcuts and custom background image attributions. Logged only when Google
is the default search provider, as these elements only appear on the Google
NTP.
This user action is of special interest to the chrome-analysis-team@. Do not
change its semantics or retire it without talking to them first.
</description>
</action>
<action name="NewTabPage_ContentSuggestions_ArticlesUsage" <action name="NewTabPage_ContentSuggestions_ArticlesUsage"
not_user_triggered="true"> not_user_triggered="true">
<owner>markusheintz@chromium.org</owner> <owner>markusheintz@chromium.org</owner>
...@@ -15418,9 +15436,10 @@ should be able to be added at any place in this file. ...@@ -15418,9 +15436,10 @@ should be able to be added at any place in this file.
</action> </action>
<action name="NTP_LinkOpenedFromContextMenu"> <action name="NTP_LinkOpenedFromContextMenu">
<owner>kmilka@chromium.org</owner> <owner>tiborg@chromium.org</owner>
<owner>ramyan@chromium.org</owner> <owner>yyushkina@chromium.org</owner>
<owner>chrome-analysis-team@google.com</owner> <owner>chrome-analysis-team@google.com</owner>
<owner>chrome-desktop-ntp@google.com</owner>
<description> <description>
Recorded when a link on the New Tab Page is opened via the context menu. Recorded when a link on the New Tab Page is opened via the context menu.
This can include: Middle-slot promos, Doodles, the One Google Bar, and This can include: Middle-slot promos, Doodles, the One Google Bar, and
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment