Commit 744ae3dd authored by Jochen Eisinger's avatar Jochen Eisinger Committed by Commit Bot

Revert "Add crash key for non-CORS-safelisted header names send by 1p apps"

This reverts commit 20a3cdfb.

Reason for revert: it's X-Chrome-offline

Original change's description:
> Add crash key for non-CORS-safelisted header names send by 1p apps
> 
> Bug: 873178
> Change-Id: I696313dd80fb0801d951ff6c6e0c50661f84a63a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000599
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731685}

TBR=tedchoc@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 873178
Change-Id: I6c0c61caec0ffb14d50a010f36aba24ed0a657e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002583Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732303}
parent 0ae29eda
......@@ -3,8 +3,6 @@
// found in the LICENSE file.
#include "base/android/jni_string.h"
#include "base/debug/crash_logging.h"
#include "base/debug/dump_without_crashing.h"
#include "base/hash/hash.h"
#include "base/metrics/histogram_functions.h"
#include "base/strings/string_util.h"
......@@ -28,17 +26,9 @@ jboolean JNI_IntentHeadersRecorder_IsCorsSafelistedHeader(
return true;
if (is_first_party) {
int hash = base::PersistentHash(base::ToLowerASCII(header_name));
base::UmaHistogramSparse("Android.IntentNonSafelistedHeaderNames", hash);
if (hash == -240302231) {
static base::debug::CrashKeyString* non_safelisted_header_name =
base::debug::AllocateCrashKeyString(
"intent_non_safelisted_header_name",
base::debug::CrashKeySize::Size256);
base::debug::ScopedCrashKeyString(non_safelisted_header_name,
header_name);
base::debug::DumpWithoutCrashing();
}
base::UmaHistogramSparse(
"Android.IntentNonSafelistedHeaderNames",
base::PersistentHash(base::ToLowerASCII(header_name)));
}
return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment