Commit 7463677b authored by Brian White's avatar Brian White Committed by Commit Bot

Remove old debug code.

Bug: 734049
Change-Id: Id44d3f31149bd0d301577c2fd06ec414c4254f84
Reviewed-on: https://chromium-review.googlesource.com/1001726Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549289}
parent 3f37c46c
...@@ -557,8 +557,7 @@ Histogram::Histogram(const char* name, ...@@ -557,8 +557,7 @@ Histogram::Histogram(const char* name,
Sample maximum, Sample maximum,
const BucketRanges* ranges) const BucketRanges* ranges)
: HistogramBase(name) { : HistogramBase(name) {
// TODO(bcwhite): Make this a DCHECK once crbug/734049 is resolved. DCHECK(ranges) << name << ": " << minimum << "-" << maximum;
CHECK(ranges) << name << ": " << minimum << "-" << maximum;
unlogged_samples_.reset(new SampleVector(HashMetricName(name), ranges)); unlogged_samples_.reset(new SampleVector(HashMetricName(name), ranges));
logged_samples_.reset(new SampleVector(unlogged_samples_->id(), ranges)); logged_samples_.reset(new SampleVector(unlogged_samples_->id(), ranges));
} }
...@@ -572,8 +571,7 @@ Histogram::Histogram(const char* name, ...@@ -572,8 +571,7 @@ Histogram::Histogram(const char* name,
HistogramSamples::Metadata* meta, HistogramSamples::Metadata* meta,
HistogramSamples::Metadata* logged_meta) HistogramSamples::Metadata* logged_meta)
: HistogramBase(name) { : HistogramBase(name) {
// TODO(bcwhite): Make this a DCHECK once crbug/734049 is resolved. DCHECK(ranges) << name << ": " << minimum << "-" << maximum;
CHECK(ranges) << name << ": " << minimum << "-" << maximum;
unlogged_samples_.reset( unlogged_samples_.reset(
new PersistentSampleVector(HashMetricName(name), ranges, meta, counts)); new PersistentSampleVector(HashMetricName(name), ranges, meta, counts));
logged_samples_.reset(new PersistentSampleVector( logged_samples_.reset(new PersistentSampleVector(
...@@ -641,15 +639,9 @@ std::unique_ptr<SampleVector> Histogram::SnapshotAllSamples() const { ...@@ -641,15 +639,9 @@ std::unique_ptr<SampleVector> Histogram::SnapshotAllSamples() const {
} }
std::unique_ptr<SampleVector> Histogram::SnapshotUnloggedSamples() const { std::unique_ptr<SampleVector> Histogram::SnapshotUnloggedSamples() const {
// TODO(bcwhite): Remove these CHECKs once crbug/734049 is resolved.
HistogramSamples* unlogged = unlogged_samples_.get();
CHECK(unlogged_samples_);
CHECK(unlogged_samples_->id());
CHECK(bucket_ranges());
std::unique_ptr<SampleVector> samples( std::unique_ptr<SampleVector> samples(
new SampleVector(unlogged_samples_->id(), bucket_ranges())); new SampleVector(unlogged_samples_->id(), bucket_ranges()));
samples->Add(*unlogged_samples_); samples->Add(*unlogged_samples_);
debug::Alias(&unlogged);
return samples; return samples;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment