Commit 747aec63 authored by Owen Min's avatar Owen Min Committed by Commit Bot

Rename machine_level_uesr_cloud_policy_browsertest

Rename machine_level_user_cloud_policy_browsertest_* to
chrome_browser_cloud_management_browsertest_*

Rename the test
MachineLevelUserCloudPolicyServiceIntegrationTest.* to
ChromeBrowserCloudManagementServiceIntegrationTest.*

Rename MachineLevelUserCloudPolicyEnrollmentTest.* to
ChromeBrowserCloudManagementEnrollmentTest.*

Bug: 1010704
Change-Id: If5887b184da8c011ba18a3c091151876b8743cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900467Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713018}
parent 19a0c68c
...@@ -52,13 +52,13 @@ ...@@ -52,13 +52,13 @@
#include "ui/views/test/widget_test.h" #include "ui/views/test/widget_test.h"
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#include "chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.h" #include "chrome/browser/policy/cloud/chrome_browser_cloud_management_browsertest_mac_util.h"
#endif #endif
using testing::_;
using testing::DoAll; using testing::DoAll;
using testing::Invoke; using testing::Invoke;
using testing::InvokeWithoutArgs; using testing::InvokeWithoutArgs;
using testing::_;
namespace em = enterprise_management; namespace em = enterprise_management;
...@@ -195,10 +195,10 @@ class PolicyFetchClientObserver : public CloudPolicyClient::Observer { ...@@ -195,10 +195,10 @@ class PolicyFetchClientObserver : public CloudPolicyClient::Observer {
} // namespace } // namespace
class MachineLevelUserCloudPolicyServiceIntegrationTest class ChromeBrowserCloudManagementServiceIntegrationTest
: public InProcessBrowserTest, : public InProcessBrowserTest,
public testing::WithParamInterface<std::string( public testing::WithParamInterface<std::string(
MachineLevelUserCloudPolicyServiceIntegrationTest::*)(void)> { ChromeBrowserCloudManagementServiceIntegrationTest::*)(void)> {
public: public:
MOCK_METHOD4(OnJobDone, MOCK_METHOD4(OnJobDone,
void(DeviceManagementService::Job*, void(DeviceManagementService::Job*,
...@@ -219,7 +219,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest ...@@ -219,7 +219,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest
if (expect_success) { if (expect_success) {
EXPECT_CALL(*this, OnJobDone(_, testing::Eq(DM_STATUS_SUCCESS), _, _)) EXPECT_CALL(*this, OnJobDone(_, testing::Eq(DM_STATUS_SUCCESS), _, _))
.WillOnce(DoAll( .WillOnce(DoAll(
Invoke(this, &MachineLevelUserCloudPolicyServiceIntegrationTest:: Invoke(this, &ChromeBrowserCloudManagementServiceIntegrationTest::
RecordToken), RecordToken),
InvokeWithoutArgs(&run_loop, &base::RunLoop::QuitWhenIdle))); InvokeWithoutArgs(&run_loop, &base::RunLoop::QuitWhenIdle)));
} else { } else {
...@@ -240,7 +240,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest ...@@ -240,7 +240,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest
g_browser_process->system_network_context_manager() g_browser_process->system_network_context_manager()
->GetSharedURLLoaderFactory(), ->GetSharedURLLoaderFactory(),
base::BindOnce( base::BindOnce(
&MachineLevelUserCloudPolicyServiceIntegrationTest::OnJobDone, &ChromeBrowserCloudManagementServiceIntegrationTest::OnJobDone,
base::Unretained(this)), base::Unretained(this)),
base::DoNothing()); base::DoNothing());
...@@ -277,7 +277,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest ...@@ -277,7 +277,7 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest
g_browser_process->system_network_context_manager() g_browser_process->system_network_context_manager()
->GetSharedURLLoaderFactory(), ->GetSharedURLLoaderFactory(),
base::BindOnce( base::BindOnce(
&MachineLevelUserCloudPolicyServiceIntegrationTest::OnJobDone, &ChromeBrowserCloudManagementServiceIntegrationTest::OnJobDone,
base::Unretained(this)), base::Unretained(this)),
base::DoNothing()); base::DoNothing());
...@@ -323,21 +323,21 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest ...@@ -323,21 +323,21 @@ class MachineLevelUserCloudPolicyServiceIntegrationTest
std::unique_ptr<LocalPolicyTestServer> test_server_; std::unique_ptr<LocalPolicyTestServer> test_server_;
}; };
IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest, IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementServiceIntegrationTest,
Registration) { Registration) {
ASSERT_TRUE(token_.empty()); ASSERT_TRUE(token_.empty());
PerformRegistration(kEnrollmentToken, kMachineName, /*expect_success=*/true); PerformRegistration(kEnrollmentToken, kMachineName, /*expect_success=*/true);
EXPECT_FALSE(token_.empty()); EXPECT_FALSE(token_.empty());
} }
IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest, IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementServiceIntegrationTest,
RegistrationNoEnrollmentToken) { RegistrationNoEnrollmentToken) {
ASSERT_TRUE(token_.empty()); ASSERT_TRUE(token_.empty());
PerformRegistration(std::string(), kMachineName, /*expect_success=*/false); PerformRegistration(std::string(), kMachineName, /*expect_success=*/false);
EXPECT_TRUE(token_.empty()); EXPECT_TRUE(token_.empty());
} }
IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest, IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementServiceIntegrationTest,
RegistrationNoMachineName) { RegistrationNoMachineName) {
ASSERT_TRUE(token_.empty()); ASSERT_TRUE(token_.empty());
PerformRegistration(kEnrollmentToken, std::string(), PerformRegistration(kEnrollmentToken, std::string(),
...@@ -345,17 +345,17 @@ IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest, ...@@ -345,17 +345,17 @@ IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest,
EXPECT_TRUE(token_.empty()); EXPECT_TRUE(token_.empty());
} }
IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyServiceIntegrationTest, IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementServiceIntegrationTest,
ChromeDesktopReport) { ChromeDesktopReport) {
em::ChromeDesktopReportRequest chrome_desktop_report; em::ChromeDesktopReportRequest chrome_desktop_report;
UploadChromeDesktopReport(&chrome_desktop_report); UploadChromeDesktopReport(&chrome_desktop_report);
} }
INSTANTIATE_TEST_SUITE_P( INSTANTIATE_TEST_SUITE_P(
MachineLevelUserCloudPolicyServiceIntegrationTestInstance, ChromeBrowserCloudManagementServiceIntegrationTestInstance,
MachineLevelUserCloudPolicyServiceIntegrationTest, ChromeBrowserCloudManagementServiceIntegrationTest,
testing::Values( testing::Values(
&MachineLevelUserCloudPolicyServiceIntegrationTest::InitTestServer)); &ChromeBrowserCloudManagementServiceIntegrationTest::InitTestServer));
class CloudPolicyStoreObserverStub : public CloudPolicyStore::Observer { class CloudPolicyStoreObserverStub : public CloudPolicyStore::Observer {
public: public:
...@@ -418,11 +418,11 @@ IN_PROC_BROWSER_TEST_F(MachineLevelUserCloudPolicyManagerTest, WithDmToken) { ...@@ -418,11 +418,11 @@ IN_PROC_BROWSER_TEST_F(MachineLevelUserCloudPolicyManagerTest, WithDmToken) {
EXPECT_TRUE(CreateAndInitManager("dummy_dm_token")); EXPECT_TRUE(CreateAndInitManager("dummy_dm_token"));
} }
class MachineLevelUserCloudPolicyEnrollmentTest class ChromeBrowserCloudManagementEnrollmentTest
: public InProcessBrowserTest, : public InProcessBrowserTest,
public ::testing::WithParamInterface<std::tuple<bool, bool, bool>> { public ::testing::WithParamInterface<std::tuple<bool, bool, bool>> {
public: public:
MachineLevelUserCloudPolicyEnrollmentTest() { ChromeBrowserCloudManagementEnrollmentTest() {
BrowserDMTokenStorage::SetForTesting(&storage_); BrowserDMTokenStorage::SetForTesting(&storage_);
storage_.SetEnrollmentToken(is_enrollment_token_valid() storage_.SetEnrollmentToken(is_enrollment_token_valid()
? kEnrollmentToken ? kEnrollmentToken
...@@ -505,10 +505,10 @@ class MachineLevelUserCloudPolicyEnrollmentTest ...@@ -505,10 +505,10 @@ class MachineLevelUserCloudPolicyEnrollmentTest
FakeBrowserDMTokenStorage storage_; FakeBrowserDMTokenStorage storage_;
ChromeBrowserCloudManagementControllerObserver observer_; ChromeBrowserCloudManagementControllerObserver observer_;
DISALLOW_COPY_AND_ASSIGN(MachineLevelUserCloudPolicyEnrollmentTest); DISALLOW_COPY_AND_ASSIGN(ChromeBrowserCloudManagementEnrollmentTest);
}; };
IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyEnrollmentTest, Test) { IN_PROC_BROWSER_TEST_P(ChromeBrowserCloudManagementEnrollmentTest, Test) {
// Test body is run only if enrollment is succeeded or failed without error // Test body is run only if enrollment is succeeded or failed without error
// message. // message.
EXPECT_TRUE(is_enrollment_token_valid() || !should_display_error_message()); EXPECT_TRUE(is_enrollment_token_valid() || !should_display_error_message());
...@@ -526,7 +526,7 @@ IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyEnrollmentTest, Test) { ...@@ -526,7 +526,7 @@ IN_PROC_BROWSER_TEST_P(MachineLevelUserCloudPolicyEnrollmentTest, Test) {
} }
INSTANTIATE_TEST_SUITE_P(, INSTANTIATE_TEST_SUITE_P(,
MachineLevelUserCloudPolicyEnrollmentTest, ChromeBrowserCloudManagementEnrollmentTest,
::testing::Combine(::testing::Bool(), ::testing::Combine(::testing::Bool(),
::testing::Bool(), ::testing::Bool(),
::testing::Bool())); ::testing::Bool()));
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef CHROME_BROWSER_POLICY_CLOUD_MACHINE_LEVEL_USER_CLOUD_POLICY_BROWSERTEST_MAC_UTIL_H_ #ifndef CHROME_BROWSER_POLICY_CLOUD_CHROME_BROWSER_CLOUD_MANAGEMENT_BROWSERTEST_MAC_UTIL_H_
#define CHROME_BROWSER_POLICY_CLOUD_MACHINE_LEVEL_USER_CLOUD_POLICY_BROWSERTEST_MAC_UTIL_H_ #define CHROME_BROWSER_POLICY_CLOUD_CHROME_BROWSER_CLOUD_MANAGEMENT_BROWSERTEST_MAC_UTIL_H_
namespace policy { namespace policy {
...@@ -15,4 +15,4 @@ void PostAppControllerNSNotifications(); ...@@ -15,4 +15,4 @@ void PostAppControllerNSNotifications();
} // namespace policy } // namespace policy
#endif // CHROME_BROWSER_POLICY_CLOUD_MACHINE_LEVEL_USER_CLOUD_POLICY_BROWSERTEST_MAC_UTIL_H_ #endif // CHROME_BROWSER_POLICY_CLOUD_CHROME_BROWSER_CLOUD_MANAGEMENT_BROWSERTEST_MAC_UTIL_H_
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.h" #include "chrome/browser/policy/cloud/chrome_browser_cloud_management_browsertest_mac_util.h"
#import <Cocoa/Cocoa.h> #import <Cocoa/Cocoa.h>
......
...@@ -1042,13 +1042,13 @@ if (!is_android) { ...@@ -1042,13 +1042,13 @@ if (!is_android) {
"../browser/plugins/flash_permission_browsertest.cc", "../browser/plugins/flash_permission_browsertest.cc",
"../browser/plugins/plugin_power_saver_browsertest.cc", "../browser/plugins/plugin_power_saver_browsertest.cc",
"../browser/plugins/plugin_response_interceptor_url_loader_throttle_browsertest.cc", "../browser/plugins/plugin_response_interceptor_url_loader_throttle_browsertest.cc",
"../browser/policy/cloud/chrome_browser_cloud_management_browsertest.cc",
"../browser/policy/cloud/cloud_policy_browsertest.cc", "../browser/policy/cloud/cloud_policy_browsertest.cc",
"../browser/policy/cloud/cloud_policy_manager_browsertest.cc", "../browser/policy/cloud/cloud_policy_manager_browsertest.cc",
"../browser/policy/cloud/cloud_policy_test_utils.cc", "../browser/policy/cloud/cloud_policy_test_utils.cc",
"../browser/policy/cloud/cloud_policy_test_utils.h", "../browser/policy/cloud/cloud_policy_test_utils.h",
"../browser/policy/cloud/component_cloud_policy_browsertest.cc", "../browser/policy/cloud/component_cloud_policy_browsertest.cc",
"../browser/policy/cloud/device_management_service_browsertest.cc", "../browser/policy/cloud/device_management_service_browsertest.cc",
"../browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc",
"../browser/policy/policy_browsertest.cc", "../browser/policy/policy_browsertest.cc",
"../browser/policy/policy_initialization_browsertest.cc", "../browser/policy/policy_initialization_browsertest.cc",
"../browser/policy/policy_network_browsertest.cc", "../browser/policy/policy_network_browsertest.cc",
...@@ -2382,7 +2382,7 @@ if (!is_android) { ...@@ -2382,7 +2382,7 @@ if (!is_android) {
"../browser/ui/webui/signin/user_manager_ui_browsertest.cc", "../browser/ui/webui/signin/user_manager_ui_browsertest.cc",
# chromeos does not support machine level user cloud policies # chromeos does not support machine level user cloud policies
"../browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc", "../browser/policy/cloud/chrome_browser_cloud_management_browsertest.cc",
] ]
} else { # !is_chromeos } else { # !is_chromeos
sources -= [ sources -= [
...@@ -2446,8 +2446,8 @@ if (!is_android) { ...@@ -2446,8 +2446,8 @@ if (!is_android) {
"//chrome:chrome_framework", "//chrome:chrome_framework",
] ]
sources += [ sources += [
"../browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.h", "../browser/policy/cloud/chrome_browser_cloud_management_browsertest_mac_util.h",
"../browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.mm", "../browser/policy/cloud/chrome_browser_cloud_management_browsertest_mac_util.mm",
"../browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm", "../browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm",
"../browser/spellchecker/spell_check_host_chrome_impl_mac_browsertest.cc", "../browser/spellchecker/spell_check_host_chrome_impl_mac_browsertest.cc",
"../browser/ui/cocoa/accelerators_cocoa_browsertest.mm", "../browser/ui/cocoa/accelerators_cocoa_browsertest.mm",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment