Commit 74824950 authored by yoav@yoav.ws's avatar yoav@yoav.ws

Renamed MediaQueryExp::create

Since MediaQueryExp::create returns a nullptr when the input string is not a valid media feature,
I've renamed it to createIfValid.

BUG=

Review URL: https://codereview.chromium.org/209443002

git-svn-id: svn://svn.chromium.org/blink/trunk@169801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 5926bfa8
......@@ -211,8 +211,7 @@ MediaQueryExp::MediaQueryExp(const String& mediaFeature, PassRefPtrWillBeRawPtr<
{
}
// FIXME - create should not return a null.
PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::create(const String& mediaFeature, CSSParserValueList* valueList)
PassOwnPtrWillBeRawPtr<MediaQueryExp> MediaQueryExp::createIfValid(const String& mediaFeature, CSSParserValueList* valueList)
{
ASSERT(!mediaFeature.isNull());
......
......@@ -40,7 +40,7 @@ class CSSParserValueList;
class MediaQueryExp : public NoBaseWillBeGarbageCollectedFinalized<MediaQueryExp> {
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
static PassOwnPtrWillBeRawPtr<MediaQueryExp> create(const String& mediaFeature, CSSParserValueList*);
static PassOwnPtrWillBeRawPtr<MediaQueryExp> createIfValid(const String& mediaFeature, CSSParserValueList*);
~MediaQueryExp();
const String& mediaFeature() const { return m_mediaFeature; }
......
......@@ -1598,7 +1598,7 @@ CSSParserValue& BisonCSSParser::sinkFloatingValue(CSSParserValue& value)
MediaQueryExp* BisonCSSParser::createFloatingMediaQueryExp(const AtomicString& mediaFeature, CSSParserValueList* values)
{
m_floatingMediaQueryExp = MediaQueryExp::create(mediaFeature, values);
m_floatingMediaQueryExp = MediaQueryExp::createIfValid(mediaFeature, values);
return m_floatingMediaQueryExp.get();
}
......
......@@ -207,7 +207,7 @@ PassOwnPtrWillBeRawPtr<MediaQuery> MediaQueryData::takeMediaQuery()
bool MediaQueryData::addExpression()
{
OwnPtrWillBeRawPtr<MediaQueryExp> expression = MediaQueryExp::create(m_mediaFeature, &m_valueList);
OwnPtrWillBeRawPtr<MediaQueryExp> expression = MediaQueryExp::createIfValid(m_mediaFeature, &m_valueList);
bool isValid = !!expression;
m_expressions->append(expression.release());
m_valueList.clear();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment