Commit 748ff2f1 authored by Alex Cooper's avatar Alex Cooper Committed by Commit Bot

Bump timeouts for WebXr Consent Failure test cases

During local development it's possible for these tests to fail due to
reaching the timout limits for polling that the error state has been
reached. This bumps up the timeout to ensure that the tests can pass in
local development environments as well as the waterfall.

Bug: 1028777
Change-Id: Iaf6d93295cfe044046ef989710f0894ee8e6b850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938031
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719400}
parent 8834f5a3
...@@ -35,7 +35,8 @@ WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F(TestConsentCancelFailsSessionCreation) { ...@@ -35,7 +35,8 @@ WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F(TestConsentCancelFailsSessionCreation) {
t->GetFileUrlForHtmlTestFile("test_webxr_consent")); t->GetFileUrlForHtmlTestFile("test_webxr_consent"));
t->EnterSessionWithUserGesture(); t->EnterSessionWithUserGesture();
t->PollJavaScriptBooleanOrFail( t->PollJavaScriptBooleanOrFail(
"sessionInfos[sessionTypes.IMMERSIVE].error != null"); "sessionInfos[sessionTypes.IMMERSIVE].error != null",
WebXrVrBrowserTestBase::kPollTimeoutMedium);
t->RunJavaScriptOrFail("verifySessionConsentError(sessionTypes.IMMERSIVE)"); t->RunJavaScriptOrFail("verifySessionConsentError(sessionTypes.IMMERSIVE)");
t->AssertNoJavaScriptErrors(); t->AssertNoJavaScriptErrors();
...@@ -53,7 +54,8 @@ WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F(TestConsentCloseFailsSessionCreation) { ...@@ -53,7 +54,8 @@ WEBXR_VR_ALL_RUNTIMES_BROWSER_TEST_F(TestConsentCloseFailsSessionCreation) {
t->GetFileUrlForHtmlTestFile("test_webxr_consent")); t->GetFileUrlForHtmlTestFile("test_webxr_consent"));
t->EnterSessionWithUserGesture(); t->EnterSessionWithUserGesture();
t->PollJavaScriptBooleanOrFail( t->PollJavaScriptBooleanOrFail(
"sessionInfos[sessionTypes.IMMERSIVE].error != null"); "sessionInfos[sessionTypes.IMMERSIVE].error != null",
WebXrVrBrowserTestBase::kPollTimeoutMedium);
t->RunJavaScriptOrFail("verifySessionConsentError(sessionTypes.IMMERSIVE)"); t->RunJavaScriptOrFail("verifySessionConsentError(sessionTypes.IMMERSIVE)");
t->AssertNoJavaScriptErrors(); t->AssertNoJavaScriptErrors();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment