Fix the flaky unit test BuiltInAppTest.Build.
The new app icon factory code in AppService calls display::Screen::GetScreen to get the scale, so in unit tests, sometime, it crashes: 0x7f3430a96390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #4 0x558ca24e91ea (anonymous namespace)::GetPrimaryDisplayScaleFactor() Modify unit tests to set the TestScreen. Built bots run 20 times, and there is no flaky tests for BuiltInAppTest.Build. BUG=1115837 Change-Id: Id3ad017f5e15dbadfc6b28ef0d65295bfcc799b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379419 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#802860}
Showing
Please register or sign in to comment