Commit 749ce8d0 authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

ios: Use mainBundle bundleVersion as part of version_lock workaround.

Bug: 1140474
Change-Id: I264270edec37ffa425a1525af5a95a9e53009310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495005Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820288}
parent 5d67a760
...@@ -271,9 +271,14 @@ void WriteDiagnosticPayloads(NSArray<MXDiagnosticPayload*>* payloads) ...@@ -271,9 +271,14 @@ void WriteDiagnosticPayloads(NSArray<MXDiagnosticPayload*>* payloads)
#endif #endif
- (void)processPayload:(MXMetricPayload*)payload API_AVAILABLE(ios(13.0)) { - (void)processPayload:(MXMetricPayload*)payload API_AVAILABLE(ios(13.0)) {
// TODO(crbug.com/1140474): See related bug for why |bundleVersion| comes from
// mainBundle instead of from version_info::GetVersionNumber(). Remove once
// iOS 14.2 reaches mass adoption.
NSString* bundleVersion =
[[NSBundle mainBundle] infoDictionary][(NSString*)kCFBundleVersionKey];
if (payload.includesMultipleApplicationVersions || if (payload.includesMultipleApplicationVersions ||
base::SysNSStringToUTF8(payload.metaData.applicationBuildVersion) != base::SysNSStringToUTF8(payload.metaData.applicationBuildVersion) !=
version_info::GetVersionNumber()) { base::SysNSStringToUTF8(bundleVersion)) {
// The metrics will be reported on the current version of Chrome. // The metrics will be reported on the current version of Chrome.
// Ignore any report that contains data from another version to avoid // Ignore any report that contains data from another version to avoid
// confusion. // confusion.
......
...@@ -17,9 +17,13 @@ ...@@ -17,9 +17,13 @@
#endif #endif
id MockMXMetadata() API_AVAILABLE(ios(13.0)) { id MockMXMetadata() API_AVAILABLE(ios(13.0)) {
// TODO(crbug.com/1140474): See related bug for why |bundleVersion| comes from
// mainBundle instead of from version_info::GetVersionNumber(). Remove once
// iOS 14.2 reaches mass adoption.
NSString* bundleVersion =
[[NSBundle mainBundle] infoDictionary][(NSString*)kCFBundleVersionKey];
id metadata = OCMClassMock([MXMetaData class]); id metadata = OCMClassMock([MXMetaData class]);
OCMStub([metadata applicationBuildVersion]) OCMStub([metadata applicationBuildVersion]).andReturn(bundleVersion);
.andReturn(base::SysUTF8ToNSString(version_info::GetVersionNumber()));
return metadata; return metadata;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment