Re-enable WebRequestAuthRequired test.

ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled
forever. It was originally disabled for flakiness, but neither the
flaky crashes nor the code which was crashing appear to exist anymore.

This CL makes some minor updates to the test expectations and re-enables
the test.

Bug: 140976,841827
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62
Reviewed-on: https://chromium-review.googlesource.com/1076683Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562546}

chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -438,9 +438,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
       message_;
 }
 
-// Flaky (sometimes crash): http://crbug.com/140976
-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
-                       DISABLED_WebRequestAuthRequired) {
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestAuthRequired) {
   CancelLoginDialog login_dialog_helper;
 
   ASSERT_TRUE(StartEmbeddedTestServer());

chrome/test/data/extensions/api_test/webrequest/test_auth_required.js

@@ -55,6 +55,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           }
         },
         { label: "onResponseStarted",
@@ -134,6 +135,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           }
         },
         { label: "onResponseStarted",
@@ -215,6 +217,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           },
           retval: {cancel: true}
         },
@@ -298,6 +301,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           },
           retval: {authCredentials: {username: "foo", password: "secret"}}
         },
@@ -379,6 +383,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           }
         },
         { label: "onResponseStarted",
@@ -460,6 +465,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           },
           retval: {cancel: true}
         },
@@ -543,6 +549,7 @@ runTests([
             challenger: {host: testServer, port: testServerPort},
             responseHeadersExist: true,
             statusLine: "HTTP/1.1 401 Unauthorized",
+            statusCode: 401,
           },
           retval: {authCredentials: {username: "foo", password: "secret"}}
         },

testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

@@ -143,6 +143,7 @@
 # http://crbug.com/841827
 -BackgroundXhrTest.HttpAuth
 -BackgroundXhrTest.TlsClientAuth
+-ExtensionWebRequestApiTest.WebRequestAuthRequired
 
 # https://crbug.com/721400
 # WebSocket with the network service