Commit 74bb01de authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Clean up old Mojo types for mojom::DebugLogsChangeHandler

This CL cleans up old Mojo types for mojom::DebugLogsChangeHandler
using PendingRemote and ReceiverSet instead of InterfacePtr
and BindingSet.

Bug: 955171
Change-Id: Iffb8cb730857f8b5ea417300f0e8b9235c88ed97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939070Reviewed-by: default avatarSam McNally <sammc@chromium.org>
Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#720821}
parent 5ccfd617
...@@ -39,10 +39,11 @@ DebugLogsManager::DebugLogsState DebugLogsManager::GetDebugLogsState() const { ...@@ -39,10 +39,11 @@ DebugLogsManager::DebugLogsState DebugLogsManager::GetDebugLogsState() const {
: DebugLogsState::kSupportedButDisabled; : DebugLogsState::kSupportedButDisabled;
} }
mojom::DebugLogsChangeHandlerPtr DebugLogsManager::GenerateInterfacePtr() { mojo::PendingRemote<mojom::DebugLogsChangeHandler>
mojom::DebugLogsChangeHandlerPtr interface_ptr; DebugLogsManager::GenerateRemote() {
bindings_.AddBinding(this, mojo::MakeRequest(&interface_ptr)); mojo::PendingRemote<mojom::DebugLogsChangeHandler> remote;
return interface_ptr; receivers_.Add(this, remote.InitWithNewPipeAndPassReceiver());
return remote;
} }
void DebugLogsManager::ChangeDebugLogsState(bool should_debug_logs_be_enabled) { void DebugLogsManager::ChangeDebugLogsState(bool should_debug_logs_be_enabled) {
......
...@@ -7,7 +7,8 @@ ...@@ -7,7 +7,8 @@
#include "base/macros.h" #include "base/macros.h"
#include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom.h" #include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom.h"
#include "mojo/public/cpp/bindings/binding_set.h" #include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/receiver_set.h"
class PrefService; class PrefService;
class PrefRegistrySimple; class PrefRegistrySimple;
...@@ -44,15 +45,15 @@ class DebugLogsManager : public mojom::DebugLogsChangeHandler { ...@@ -44,15 +45,15 @@ class DebugLogsManager : public mojom::DebugLogsChangeHandler {
// mojom::DebugLogsManager: // mojom::DebugLogsManager:
void ChangeDebugLogsState(bool should_debug_logs_be_enabled) override; void ChangeDebugLogsState(bool should_debug_logs_be_enabled) override;
// Generates an InterfacePtr bound to this object. // Generates an PendingRemote bound to this object.
mojom::DebugLogsChangeHandlerPtr GenerateInterfacePtr(); mojo::PendingRemote<mojom::DebugLogsChangeHandler> GenerateRemote();
private: private:
bool AreDebugLogsSupported() const; bool AreDebugLogsSupported() const;
const std::string primary_user_email_; const std::string primary_user_email_;
PrefService* pref_service_ = nullptr; PrefService* pref_service_ = nullptr;
mojo::BindingSet<mojom::DebugLogsChangeHandler> bindings_; mojo::ReceiverSet<mojom::DebugLogsChangeHandler> receivers_;
DISALLOW_COPY_AND_ASSIGN(DebugLogsManager); DISALLOW_COPY_AND_ASSIGN(DebugLogsManager);
}; };
......
...@@ -24,6 +24,7 @@ interface BluetoothInternalsHandler { ...@@ -24,6 +24,7 @@ interface BluetoothInternalsHandler {
// not supported (e.g., the required flags are disabled or the logged-in user // not supported (e.g., the required flags are disabled or the logged-in user
// is not eligible), null is returned. When a valid handler is returned, an // is not eligible), null is returned. When a valid handler is returned, an
// extra boolean is provided which represents the initial state of the toggle. // extra boolean is provided which represents the initial state of the toggle.
GetDebugLogsChangeHandler() => (DebugLogsChangeHandler? handler, GetDebugLogsChangeHandler()
bool initial_toggle_value); => (pending_remote<DebugLogsChangeHandler>? handler,
bool initial_toggle_value);
}; };
...@@ -12,7 +12,6 @@ ...@@ -12,7 +12,6 @@
#include "chrome/browser/chromeos/bluetooth/debug_logs_manager.h" #include "chrome/browser/chromeos/bluetooth/debug_logs_manager.h"
#include "device/bluetooth/adapter.h" #include "device/bluetooth/adapter.h"
#include "device/bluetooth/bluetooth_adapter_factory.h" #include "device/bluetooth/bluetooth_adapter_factory.h"
#include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/pending_remote.h" #include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/self_owned_receiver.h" #include "mojo/public/cpp/bindings/self_owned_receiver.h"
#include "url/gurl.h" #include "url/gurl.h"
...@@ -39,7 +38,7 @@ void BluetoothInternalsHandler::GetAdapter(GetAdapterCallback callback) { ...@@ -39,7 +38,7 @@ void BluetoothInternalsHandler::GetAdapter(GetAdapterCallback callback) {
void BluetoothInternalsHandler::GetDebugLogsChangeHandler( void BluetoothInternalsHandler::GetDebugLogsChangeHandler(
GetDebugLogsChangeHandlerCallback callback) { GetDebugLogsChangeHandlerCallback callback) {
mojom::DebugLogsChangeHandlerPtr handler_ptr; mojo::PendingRemote<mojom::DebugLogsChangeHandler> handler_remote;
bool initial_toggle_value = false; bool initial_toggle_value = false;
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
...@@ -52,18 +51,18 @@ void BluetoothInternalsHandler::GetDebugLogsChangeHandler( ...@@ -52,18 +51,18 @@ void BluetoothInternalsHandler::GetDebugLogsChangeHandler(
switch (state) { switch (state) {
case DebugLogsManager::DebugLogsState::kNotSupported: case DebugLogsManager::DebugLogsState::kNotSupported:
// Leave |handler_ptr| null and |initial_toggle_value| false. // Leave |handler_remote| NullRemote and |initial_toggle_value| false.
break; break;
case DebugLogsManager::DebugLogsState::kSupportedAndEnabled: case DebugLogsManager::DebugLogsState::kSupportedAndEnabled:
initial_toggle_value = true; initial_toggle_value = true;
FALLTHROUGH; FALLTHROUGH;
case DebugLogsManager::DebugLogsState::kSupportedButDisabled: case DebugLogsManager::DebugLogsState::kSupportedButDisabled:
handler_ptr = debug_logs_manager_->GenerateInterfacePtr(); handler_remote = debug_logs_manager_->GenerateRemote();
break; break;
} }
#endif #endif
std::move(callback).Run(std::move(handler_ptr), initial_toggle_value); std::move(callback).Run(std::move(handler_remote), initial_toggle_value);
} }
void BluetoothInternalsHandler::OnGetAdapter( void BluetoothInternalsHandler::OnGetAdapter(
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "base/macros.h" #include "base/macros.h"
#include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom.h" #include "chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom.h"
#include "device/bluetooth/bluetooth_adapter.h" #include "device/bluetooth/bluetooth_adapter.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/pending_receiver.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h" #include "mojo/public/cpp/bindings/receiver.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment