Introduce call_stack_profile_encoding.{cc,h}

This is to remove duplicated code in call_stack_profile_builder.cc and
call_stack_profile_collector.cc.

Bug: 851163
Change-Id: I304aa107f84f1d4072f3a3eb5dd0e58aed52a30b
Reviewed-on: https://chromium-review.googlesource.com/1176197Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583478}

components/metrics/BUILD.gn

@@ -261,6 +261,8 @@ source_set("call_stack_profile") {
   sources = [
     "call_stack_profile_builder.cc",
     "call_stack_profile_builder.h",
+    "call_stack_profile_encoding.cc",
+    "call_stack_profile_encoding.h",
     "call_stack_profile_params.h",
   ]
 

components/metrics/call_stack_profile_builder.cc

@@ -12,6 +12,7 @@
 #include "base/logging.h"
 #include "base/metrics/metrics_hashes.h"
 #include "base/stl_util.h"
+#include "components/metrics/call_stack_profile_encoding.h"
 
 namespace metrics {
 
@@ -114,70 +115,6 @@ void CopyAnnotationsToProto(uint32_t new_milestones,
   }
 }
 
-// Translates CallStackProfileParams's process to the corresponding execution
-// context Process.
-Process ToExecutionContextProcess(CallStackProfileParams::Process process) {
-  switch (process) {
-    case CallStackProfileParams::UNKNOWN_PROCESS:
-      return UNKNOWN_PROCESS;
-    case CallStackProfileParams::BROWSER_PROCESS:
-      return BROWSER_PROCESS;
-    case CallStackProfileParams::RENDERER_PROCESS:
-      return RENDERER_PROCESS;
-    case CallStackProfileParams::GPU_PROCESS:
-      return GPU_PROCESS;
-    case CallStackProfileParams::UTILITY_PROCESS:
-      return UTILITY_PROCESS;
-    case CallStackProfileParams::ZYGOTE_PROCESS:
-      return ZYGOTE_PROCESS;
-    case CallStackProfileParams::SANDBOX_HELPER_PROCESS:
-      return SANDBOX_HELPER_PROCESS;
-    case CallStackProfileParams::PPAPI_PLUGIN_PROCESS:
-      return PPAPI_PLUGIN_PROCESS;
-    case CallStackProfileParams::PPAPI_BROKER_PROCESS:
-      return PPAPI_BROKER_PROCESS;
-  }
-  NOTREACHED();
-  return UNKNOWN_PROCESS;
-}
-
-// Translates CallStackProfileParams's thread to the corresponding
-// SampledProfile Thread.
-Thread ToExecutionContextThread(CallStackProfileParams::Thread thread) {
-  switch (thread) {
-    case CallStackProfileParams::UNKNOWN_THREAD:
-      return UNKNOWN_THREAD;
-    case CallStackProfileParams::MAIN_THREAD:
-      return MAIN_THREAD;
-    case CallStackProfileParams::IO_THREAD:
-      return IO_THREAD;
-    case CallStackProfileParams::COMPOSITOR_THREAD:
-      return COMPOSITOR_THREAD;
-  }
-  NOTREACHED();
-  return UNKNOWN_THREAD;
-}
-
-// Translates CallStackProfileParams's trigger to the corresponding
-// SampledProfile TriggerEvent.
-SampledProfile::TriggerEvent ToSampledProfileTriggerEvent(
-    CallStackProfileParams::Trigger trigger) {
-  switch (trigger) {
-    case CallStackProfileParams::UNKNOWN:
-      return SampledProfile::UNKNOWN_TRIGGER_EVENT;
-    case CallStackProfileParams::PROCESS_STARTUP:
-      return SampledProfile::PROCESS_STARTUP;
-    case CallStackProfileParams::JANKY_TASK:
-      return SampledProfile::JANKY_TASK;
-    case CallStackProfileParams::THREAD_HUNG:
-      return SampledProfile::THREAD_HUNG;
-    case CallStackProfileParams::PERIODIC_COLLECTION:
-      return SampledProfile::PERIODIC_COLLECTION;
-  }
-  NOTREACHED();
-  return SampledProfile::UNKNOWN_TRIGGER_EVENT;
-}
-
 }  // namespace
 
 // CallStackProfileBuilder::Frame ---------------------------------------------

components/metrics/call_stack_profile_collector.cc

@@ -7,42 +7,12 @@
 #include <memory>
 #include <utility>
 
+#include "components/metrics/call_stack_profile_encoding.h"
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 
 namespace metrics {
 
-namespace {
-
-// Translates CallStackProfileParams's process to the corresponding execution
-// context Process.
-Process ToExecutionContextProcess(CallStackProfileParams::Process process) {
-  switch (process) {
-    case CallStackProfileParams::UNKNOWN_PROCESS:
-      return UNKNOWN_PROCESS;
-    case CallStackProfileParams::BROWSER_PROCESS:
-      return BROWSER_PROCESS;
-    case CallStackProfileParams::RENDERER_PROCESS:
-      return RENDERER_PROCESS;
-    case CallStackProfileParams::GPU_PROCESS:
-      return GPU_PROCESS;
-    case CallStackProfileParams::UTILITY_PROCESS:
-      return UTILITY_PROCESS;
-    case CallStackProfileParams::ZYGOTE_PROCESS:
-      return ZYGOTE_PROCESS;
-    case CallStackProfileParams::SANDBOX_HELPER_PROCESS:
-      return SANDBOX_HELPER_PROCESS;
-    case CallStackProfileParams::PPAPI_PLUGIN_PROCESS:
-      return PPAPI_PLUGIN_PROCESS;
-    case CallStackProfileParams::PPAPI_BROKER_PROCESS:
-      return PPAPI_BROKER_PROCESS;
-  }
-  NOTREACHED();
-  return UNKNOWN_PROCESS;
-}
-
-}  // namespace
-
 CallStackProfileCollector::CallStackProfileCollector(
     CallStackProfileParams::Process expected_process)
     : expected_process_(expected_process) {}

components/metrics/call_stack_profile_encoding.cc

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/metrics/call_stack_profile_encoding.h"
+
+namespace metrics {
+
+Process ToExecutionContextProcess(CallStackProfileParams::Process process) {
+  switch (process) {
+    case CallStackProfileParams::UNKNOWN_PROCESS:
+      return UNKNOWN_PROCESS;
+    case CallStackProfileParams::BROWSER_PROCESS:
+      return BROWSER_PROCESS;
+    case CallStackProfileParams::RENDERER_PROCESS:
+      return RENDERER_PROCESS;
+    case CallStackProfileParams::GPU_PROCESS:
+      return GPU_PROCESS;
+    case CallStackProfileParams::UTILITY_PROCESS:
+      return UTILITY_PROCESS;
+    case CallStackProfileParams::ZYGOTE_PROCESS:
+      return ZYGOTE_PROCESS;
+    case CallStackProfileParams::SANDBOX_HELPER_PROCESS:
+      return SANDBOX_HELPER_PROCESS;
+    case CallStackProfileParams::PPAPI_PLUGIN_PROCESS:
+      return PPAPI_PLUGIN_PROCESS;
+    case CallStackProfileParams::PPAPI_BROKER_PROCESS:
+      return PPAPI_BROKER_PROCESS;
+  }
+  NOTREACHED();
+  return UNKNOWN_PROCESS;
+}
+
+Thread ToExecutionContextThread(CallStackProfileParams::Thread thread) {
+  switch (thread) {
+    case CallStackProfileParams::UNKNOWN_THREAD:
+      return UNKNOWN_THREAD;
+    case CallStackProfileParams::MAIN_THREAD:
+      return MAIN_THREAD;
+    case CallStackProfileParams::IO_THREAD:
+      return IO_THREAD;
+    case CallStackProfileParams::COMPOSITOR_THREAD:
+      return COMPOSITOR_THREAD;
+  }
+  NOTREACHED();
+  return UNKNOWN_THREAD;
+}
+
+SampledProfile::TriggerEvent ToSampledProfileTriggerEvent(
+    CallStackProfileParams::Trigger trigger) {
+  switch (trigger) {
+    case CallStackProfileParams::UNKNOWN:
+      return SampledProfile::UNKNOWN_TRIGGER_EVENT;
+    case CallStackProfileParams::PROCESS_STARTUP:
+      return SampledProfile::PROCESS_STARTUP;
+    case CallStackProfileParams::JANKY_TASK:
+      return SampledProfile::JANKY_TASK;
+    case CallStackProfileParams::THREAD_HUNG:
+      return SampledProfile::THREAD_HUNG;
+    case CallStackProfileParams::PERIODIC_COLLECTION:
+      return SampledProfile::PERIODIC_COLLECTION;
+  }
+  NOTREACHED();
+  return SampledProfile::UNKNOWN_TRIGGER_EVENT;
+}
+
+}  // namespace metrics

components/metrics/call_stack_profile_encoding.h

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_CALL_STACK_PROFILE_ENCODING_H_
+#define COMPONENTS_METRICS_CALL_STACK_PROFILE_ENCODING_H_
+
+#include "components/metrics/call_stack_profile_params.h"
+#include "third_party/metrics_proto/sampled_profile.pb.h"
+
+namespace metrics {
+
+// Translates CallStackProfileParams's process to the corresponding execution
+// context Process.
+Process ToExecutionContextProcess(CallStackProfileParams::Process process);
+
+// Translates CallStackProfileParams's thread to the corresponding
+// SampledProfile Thread.
+Thread ToExecutionContextThread(CallStackProfileParams::Thread thread);
+
+// Translates CallStackProfileParams's trigger to the corresponding
+// SampledProfile TriggerEvent.
+SampledProfile::TriggerEvent ToSampledProfileTriggerEvent(
+    CallStackProfileParams::Trigger trigger);
+
+}  // namespace metrics
+
+#endif  // COMPONENTS_METRICS_CALL_STACK_PROFILE_ENCODING_H_