Commit 74e3ee71 authored by jeremy@chromium.org's avatar jeremy@chromium.org

[Telemetry] rename _needs_browser_restart_after_each_run -> <...>_each_page

Rename to reflect what this actually does.

BUG=350832
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/192613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255937 0039d316-1c4b-4281-b951-d872f2087c98
parent 22a49955
......@@ -45,7 +45,7 @@ class _ContextLostValidator(page_test.PageTest):
# after each run, but if more tests are added which crash the GPU
# process, then it will.
super(_ContextLostValidator, self).__init__(
'ValidatePage', needs_browser_restart_after_each_run=True)
'ValidatePage', needs_browser_restart_after_each_page=True)
def CustomizeBrowserOptions(self, options):
options.AppendExtraBrowserArgs(
......
......@@ -21,7 +21,7 @@ test_harness_script = r"""
class GpuProcessValidator(page_test.PageTest):
def __init__(self):
super(GpuProcessValidator, self).__init__('ValidatePage',
needs_browser_restart_after_each_run=True)
needs_browser_restart_after_each_page=True)
def CustomizeBrowserOptions(self, options):
options.AppendExtraBrowserArgs('--enable-gpu-benchmarking')
......
......@@ -16,7 +16,7 @@ class Startup(page_measurement.PageMeasurement):
"""
def __init__(self, action_name_to_run = ''):
super(Startup, self).__init__(needs_browser_restart_after_each_run=True,
super(Startup, self).__init__(needs_browser_restart_after_each_page=True,
action_name_to_run=action_name_to_run)
def AddCommandLineOptions(self, parser):
......
......@@ -39,13 +39,13 @@ class PageMeasurement(page_test.PageTest):
"""
def __init__(self,
action_name_to_run='',
needs_browser_restart_after_each_run=False,
needs_browser_restart_after_each_page=False,
discard_first_result=False,
clear_cache_before_each_run=False):
super(PageMeasurement, self).__init__(
'_RunTest',
action_name_to_run,
needs_browser_restart_after_each_run,
needs_browser_restart_after_each_page,
discard_first_result,
clear_cache_before_each_run)
......
......@@ -304,9 +304,9 @@ class PageRunnerTests(unittest.TestCase):
def __init__(self,
test_method_name,
action_name_to_run='',
needs_browser_restart_after_each_run=False):
needs_browser_restart_after_each_page=False):
super(TestOneTab, self).__init__(test_method_name, action_name_to_run,
needs_browser_restart_after_each_run)
needs_browser_restart_after_each_page)
self._browser = None
def DidStartBrowser(self, browser):
......
......@@ -59,7 +59,7 @@ class PageTest(object):
def __init__(self,
test_method_name,
action_name_to_run='',
needs_browser_restart_after_each_run=False,
needs_browser_restart_after_each_page=False,
discard_first_result=False,
clear_cache_before_each_run=False,
attempts=3,
......@@ -72,8 +72,8 @@ class PageTest(object):
raise ValueError, 'No such method %s.%s' % (
self.__class_, test_method_name) # pylint: disable=E1101
self._action_name_to_run = action_name_to_run
self._needs_browser_restart_after_each_run = (
needs_browser_restart_after_each_run)
self._needs_browser_restart_after_each_page = (
needs_browser_restart_after_each_page)
self._discard_first_result = discard_first_result
self._clear_cache_before_each_run = clear_cache_before_each_run
self._close_tabs_before_run = True
......@@ -152,7 +152,7 @@ class PageTest(object):
This returns true if the test needs to unconditionally restart the
browser for each page. It may be called before the browser is started.
"""
return self._needs_browser_restart_after_each_run
return self._needs_browser_restart_after_each_page
def StopBrowserAfterPage(self, browser, page): # pylint: disable=W0613
"""Should the browser be stopped after the page is run?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment