Commit 74f6cdc9 authored by Daniel Cheng's avatar Daniel Cheng Committed by Commit Bot

[blink] Remove SendOrientationChangeEvent from Blink public API

Now that widget messages are handled in Blink, there's no need to expose
this method through the public API.

Change-Id: Ica1b737f0095d853fd021b8ce96e694a25772438
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518791Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824021}
parent 2c8bc0f8
......@@ -281,11 +281,6 @@ class WebLocalFrame : public WebFrame {
virtual void BlinkFeatureUsageReport(blink::mojom::WebFeature feature) = 0;
// Orientation Changes ----------------------------------------------------
// Notify the frame that the screen orientation has changed.
virtual void SendOrientationChangeEvent() = 0;
// CSS3 Paged Media ----------------------------------------------------
// Returns the type of @page size styling for the given page.
......
......@@ -2338,7 +2338,7 @@ void WebFrameWidgetBase::SetPageScaleStateAndLimits(
}
void WebFrameWidgetBase::OrientationChanged() {
LocalRoot()->SendOrientationChangeEvent();
local_root_->SendOrientationChangeEvent();
}
void WebFrameWidgetBase::DidUpdateSurfaceAndScreen(
......
......@@ -135,7 +135,6 @@ class CORE_EXPORT WebLocalFrameImpl final
void SetReferrerForRequest(WebURLRequest&, const WebURL& referrer) override;
bool IsNavigationScheduledWithin(base::TimeDelta interval) const override;
void BlinkFeatureUsageReport(blink::mojom::WebFeature feature) override;
void SendOrientationChangeEvent() override;
PageSizeType GetPageSizeType(uint32_t page_index) override;
void GetPageDescription(uint32_t page_index,
WebPrintPageDescription*) override;
......@@ -416,6 +415,8 @@ class CORE_EXPORT WebLocalFrameImpl final
return GetFrame() ? GetFrame()->View() : nullptr;
}
void SendOrientationChangeEvent();
void SetDevToolsAgentImpl(WebDevToolsAgentImpl*);
WebDevToolsAgentImpl* DevToolsAgentImpl();
......
......@@ -243,10 +243,7 @@ TEST_F(ScreenOrientationControllerTest, PageVisibilityCrash) {
// referenced before this.
ScreenOrientation::Create(frame->DomWindow());
page->SetVisibilityState(mojom::blink::PageVisibilityState::kHidden, false);
web_view_helper.GetWebView()
->MainFrame()
->ToWebLocalFrame()
->SendOrientationChangeEvent();
web_view_helper.LocalMainFrame()->SendOrientationChangeEvent();
page->SetVisibilityState(mojom::blink::PageVisibilityState::kVisible, false);
// When the iframe's orientation is initialized, it should be properly synced.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment