Commit 74f89d83 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Temporarily disable DevTools sources tests

These tests contain race-conditions in the way that CodeMirror is booted
up. When making cm_modes/ an ES module [1] these tests started to fail.
Closer inspection showed that there are numerous Promises not being
awaited, which causes the test to eagerly resume execution.

Note however that in the real application, the race-condition is WAI and
does not cause any issues. It is only in the synthetic testing
environment that this issue occurs.

After the ES modules migration, we will refactor the classes to properly
handle Promises and enable the test again.

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1928924

Bug: 1006759
Change-Id: Ic213897def208c148034632627924f31c012cca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939791
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719567}
parent 8b297f25
......@@ -5901,3 +5901,8 @@ crbug.com/1028116 virtual/gpu-rasterization/images/yuv-decode-eligible/color-pro
crbug.com/1028116 virtual/gpu-rasterization/images/yuv-decode-eligible/webp-color-profile-lossy.html [ Pass Failure ]
crbug.com/833100 [ Mac ] external/wpt/battery-status/battery-full-manual.https.html [ Pass Failure ]
# Tests include race-conditions that will be fixed after DevTools fully uses ES modules
crbug.com/1006759 http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function.js [ Pass Failure ]
crbug.com/1006759 http/tests/devtools/sources/debugger-ui/continue-to-location-markers.js [ Pass Failure ]
crbug.com/1006759 http/tests/devtools/sources/debugger-ui/popover-for-spread-operator.js [ Pass Failure ]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment