Commit 75542186 authored by Tien-Ren Chen's avatar Tien-Ren Chen Committed by Commit Bot

Revert "Android: Re-enable lint"

This reverts commit a207e0dd.

Reason for revert: Lint error in downstream code.

Original change's description:
> Android: Re-enable lint
> 
> Android lint has been failing due to API level mismatch between lint and
> platform-tools (26 vs 25). This is causing new lint errors to be
> introduced. Ignore the API mismatch for now and re-enable lint so it at
> least catches all other issues.
> 
> API warning will be re-enabled after platform-tools is rolled.
> 
> Bug: 739746,746409
> Change-Id: I339560498544462732300c5030381a0c67f25f1b
> Reviewed-on: https://chromium-review.googlesource.com/577593
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487918}

TBR=mthiesse@chromium.org,wnwen@chromium.org,agrieve@chromium.org

Change-Id: I4857cf1ba5f10b009155693a803df922036f1878
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 739746, 746409
Reviewed-on: https://chromium-review.googlesource.com/578059Reviewed-by: default avatarTien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487983}
parent 09eab17a
......@@ -189,8 +189,6 @@ Still reading?
<issue id="MissingVersion">
<ignore path="AndroidManifest.xml"/>
</issue>
<!-- TODO(crbug.com/739746): Remove once platform-tools is updated. -->
<issue id="NewApi" severity="ignore"/>
<issue id="NewApi">
<ignore regexp="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17"/>
<ignore regexp="chrome/android/java/res/values-v17/styles.xml"/>
......@@ -236,7 +234,6 @@ Still reading?
</issue>
<issue id="PackageManagerGetSignatures">
<ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java"/>
<ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/customtabs/OriginVerifier.java"/>
</issue>
<issue id="PluralsCandidate" severity="Error">
<ignore regexp="chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml"/>
......
......@@ -52,7 +52,7 @@ if (is_android) {
# Purposefully repeated so that downstream can change
# default_android_sdk_root without changing lint version.
default_lint_android_sdk_root = "//third_party/android_tools/sdk"
default_lint_android_sdk_version = "26"
default_lint_android_sdk_version = "25"
}
if (!defined(default_extras_android_sdk_root)) {
......
......@@ -117,9 +117,6 @@ public class VrShellDelegate implements ApplicationStatus.ActivityStateListener,
private static VrShellDelegate sInstance;
private static VrBroadcastReceiver sVrBroadcastReceiver;
private static boolean sRegisteredDaydreamHook = false;
// TODO(crbug.com/746409): Remove this suppression after this lint error is fixed.
@SuppressWarnings("StaticFieldLeak")
private static View sBlackOverlayView;
private ChromeActivity mActivity;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment